Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: src/objects.h

Issue 15943002: v8 typed arrays: add DataView type (Closed)
Patch Set: v8 typed arrays: add DataView type, v2 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 8420069b2627e75384591bb81295871029570efe..5475344d499b6938b55a49f06231106b7e85f88a 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -57,6 +57,7 @@
// - JSObject
// - JSArray
// - JSArrayBuffer
+// - JSDataView
// - JSTypedArray
// - JSSet
// - JSMap
@@ -401,6 +402,7 @@ const int kStubMinorKeyBits = kBitsPerInt - kSmiTagSize - kStubMajorKeyBits;
V(JS_GLOBAL_PROXY_TYPE) \
V(JS_ARRAY_TYPE) \
V(JS_ARRAY_BUFFER_TYPE) \
+ V(JS_DATA_VIEW_TYPE) \
V(JS_TYPED_ARRAY_TYPE) \
V(JS_PROXY_TYPE) \
V(JS_WEAK_MAP_TYPE) \
@@ -734,6 +736,7 @@ enum InstanceType {
JS_GLOBAL_PROXY_TYPE,
JS_ARRAY_TYPE,
JS_ARRAY_BUFFER_TYPE,
+ JS_DATA_VIEW_TYPE,
JS_TYPED_ARRAY_TYPE,
JS_SET_TYPE,
JS_MAP_TYPE,
@@ -982,6 +985,7 @@ class MaybeObject BASE_EMBEDDED {
V(Boolean) \
V(JSArray) \
V(JSArrayBuffer) \
+ V(JSDataView) \
V(JSTypedArray) \
V(JSProxy) \
V(JSFunctionProxy) \
@@ -8793,6 +8797,40 @@ class JSArrayBuffer: public JSObject {
};
+class JSDataView: public JSObject {
+ public:
+ // [buffer]: ArrayBuffer that this data view views.
+ DECL_ACCESSORS(buffer, Object)
+
+ // [byte_length]: offset of data view in bytes.
+ DECL_ACCESSORS(byte_offset, Object)
+
+ // [byte_length]: length of data view in bytes.
+ DECL_ACCESSORS(byte_length, Object)
+
+ // Casting.
+ static inline JSDataView* cast(Object* obj);
+
+ // Dispatched behavior.
+ DECLARE_PRINTER(JSDataView)
+ DECLARE_VERIFIER(JSDataView)
+
+ template <typename TypeName>
+ TypeName Get(size_t byte_offset, bool little_endian = false);
+
+ template <typename TypeName>
+ void Set(size_t byte_offset, TypeName value, bool little_endian = false);
+
+ static const int kBufferOffset = JSObject::kHeaderSize;
+ static const int kByteOffsetOffset = kBufferOffset + kPointerSize;
+ static const int kByteLengthOffset = kByteOffsetOffset + kPointerSize;
+ static const int kSize = kByteLengthOffset + kPointerSize;
+
+ private:
+ DISALLOW_IMPLICIT_CONSTRUCTORS(JSDataView);
+};
+
+
class JSTypedArray: public JSObject {
public:
// [buffer]: ArrayBuffer that this typed array views.

Powered by Google App Engine
This is Rietveld 408576698