v8 typed arrays: add DataView type

src/objects-debug.cc

Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index 891f0d2302daee66039130097592cd9981b56564..4a7fe19eeafb715734408dd9fe0e8ed52273dab7 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -201,6 +201,9 @@ void HeapObject::HeapObjectVerify() {
     case JS_ARRAY_BUFFER_TYPE:
       JSArrayBuffer::cast(this)->JSArrayBufferVerify();
       break;
+    case JS_DATA_VIEW_TYPE:
+      JSDataView::cast(this)->JSDataViewVerify();
+      break;
     case JS_TYPED_ARRAY_TYPE:
       JSTypedArray::cast(this)->JSTypedArrayVerify();
       break;
@@ -741,6 +744,7 @@ void JSFunctionProxy::JSFunctionProxyVerify() {
   VerifyPointer(construct_trap());
 }
 
+
 void JSArrayBuffer::JSArrayBufferVerify() {
   CHECK(IsJSArrayBuffer());
   JSObjectVerify();
@@ -750,6 +754,25 @@ void JSArrayBuffer::JSArrayBufferVerify() {
 }
 
 
+void JSDataView::JSDataViewVerify() {
+  CHECK(IsJSDataView());
+  JSObjectVerify();
+
+  VerifyPointer(buffer());
+  CHECK(buffer()->IsJSArrayBuffer() || buffer()->IsUndefined());
+
+  VerifyPointer(byte_offset());
+  CHECK(byte_offset()->IsSmi() || byte_offset()->IsHeapNumber()

[Sven Panne, 2013/05/24 06:58:25]

Use IsNumber() here and below.

[bnoordhuis, 2013/05/24 11:49:03]

Why is that? I ask because JSArrayBufferVerify() uses the same check.

[bnoordhuis, 2013/05/24 11:53:52]

Never mind, I see that IsNumber() is just IsSmi() || IsHeapNumber().  Want me to
update JSArrayBufferVerify() as well?

[Sven Panne, 2013/05/24 12:19:20]

This would be nice.

+        || byte_offset()->IsUndefined());
+
+  VerifyPointer(byte_length());
+  CHECK(byte_length()->IsSmi() || byte_length()->IsHeapNumber()
+        || byte_length()->IsUndefined());
+
+  VerifyPointer(elements());
+}
+
+
 void JSTypedArray::JSTypedArrayVerify() {
   CHECK(IsJSTypedArray());
   JSObjectVerify();