v8 typed arrays: add DataView type

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1333 matching lines @@
   bool IsRegExp() const;
 
 
   /**
    * Returns true if this value is an ArrayBuffer.
    * This is an experimental feature.
    */
   bool IsArrayBuffer() const;
 
   /**
+   * Returns true if this value is a DataView.
+   * This is an experimental feature.
+   */
+  bool IsDataView() const;
+
+  /**
    * Returns true if this value is one of TypedArrays.
    * This is an experimental feature.
    */
   bool IsTypedArray() const;
 
   /**
    * Returns true if this value is an Uint8Array.
    * This is an experimental feature.
    */
   bool IsUint8Array() const;
@@ skipping 1033 matching lines @@
 
   static const int kInternalFieldCount = V8_ARRAY_BUFFER_INTERNAL_FIELD_COUNT;
 
  private:
   ArrayBuffer();
   static void CheckCast(Value* obj);
 };
 
 
 /**
+ * An instance of the built-in ArrayBuffer constructor (ES6 draft 15.13.5).
+ * This API is experimental and may change significantly.
+ */
+class V8EXPORT DataView : public Object {
+ public:
+  /**
+   * Returns underlying ArrayBuffer.
+   */
+  Local<ArrayBuffer> Buffer();
+
+  /**
+   * Byte offset in |Buffer|
+   */
+  size_t ByteOffset() const;
+
+  /**
+   * Size of data view in bytes.
+   */
+  size_t ByteLength() const;
+
+  /**
+   * Raw pointer to the buffer view data.
+   */
+  void* Data() const;
+
+  static Local<DataView> New(Handle<ArrayBuffer> array_buffer,
+                             size_t byte_offset,
+                             size_t byte_length);
+  V8_INLINE(static DataView* Cast(Value* obj));
+
+  /**
+   * Return the value at |byte_offset| or 0 if |byte_offset| is out of range.
+   */
+  int8_t GetInt8(size_t byte_offset) const;
+
+  /**
+   * Return the value at |byte_offset| or 0 if |byte_offset| is out of range.
+   */
+  uint8_t GetUint8(size_t byte_offset) const;

[bnoordhuis, 2013/05/23 22:59:04]

I'd be okay with removing these. I added them for the sake of convenience.

If you keep them, it might be worth it to inline them in v8.h - though that
might make unwrapping the JSDataView kind of icky.

+
+  /**
+   * Return the value at |byte_offset| or 0 if |byte_offset| is out of range.
+   */
+  int16_t GetInt16(size_t byte_offset, bool little_endian = false) const;
+
+  /**
+   * Return the value at |byte_offset| or 0 if |byte_offset| is out of range.
+   * Reads a big-endian value unless |little_endian| is true.
+   */
+  uint16_t GetUint16(size_t byte_offset, bool little_endian = false) const;
+
+  /**
+   * Return the value at |byte_offset| or 0 if |byte_offset| is out of range.
+   * Reads a big-endian value unless |little_endian| is true.
+   */
+  int32_t GetInt32(size_t byte_offset, bool little_endian = false) const;
+
+  /**
+   * Return the value at |byte_offset| or 0 if |byte_offset| is out of range.
+   * Reads a big-endian value unless |little_endian| is true.
+   */
+  uint32_t GetUint32(size_t byte_offset, bool little_endian = false) const;
+
+  /**
+   * Return the value at |byte_offset| or 0 if |byte_offset| is out of range.
+   * Reads a big-endian value unless |little_endian| is true.
+   */
+  float GetFloat32(size_t byte_offset, bool little_endian = false) const;
+
+  /**
+   * Return the value at |byte_offset| or 0 if |byte_offset| is out of range.
+   * Reads a big-endian value unless |little_endian| is true.
+   */
+  double GetFloat64(size_t byte_offset, bool little_endian = false) const;
+
+  /**
+   * Set the value at |byte_offset| to |value|. Does nothing if |byte_offset|
+   * is out of range.
+   */
+  void SetInt8(size_t byte_offset, int8_t value);
+
+  /**
+   * Set the value at |byte_offset| to |value|. Does nothing if |byte_offset|
+   * is out of range.
+   */
+  void SetUint8(size_t byte_offset, uint8_t value);
+
+  /**
+   * Set the value at |byte_offset| to |value|. Does nothing if |byte_offset|
+   * is out of range. Writes a big-endian value unless |little_endian| is true.
+   */
+  void SetInt16(size_t byte_offset, int16_t value, bool little_endian = false);
+
+  /**
+   * Set the value at |byte_offset| to |value|. Does nothing if |byte_offset|
+   * is out of range.
+   */
+  void SetUint16(size_t byte_offset,
+                 uint16_t value,
+                 bool little_endian = false);
+
+  /**
+   * Set the value at |byte_offset| to |value|. Does nothing if |byte_offset|
+   * is out of range. Writes a big-endian value unless |little_endian| is true.
+   */
+  void SetInt32(size_t byte_offset, int32_t value, bool little_endian = false);
+
+  /**
+   * Set the value at |byte_offset| to |value|. Does nothing if |byte_offset|
+   * is out of range. Writes a big-endian value unless |little_endian| is true.
+   */
+  void SetUint32(size_t byte_offset,
+                 uint32_t value,
+                 bool little_endian = false);
+
+  /**
+   * Set the value at |byte_offset| to |value|. Does nothing if |byte_offset|
+   * is out of range. Writes a big-endian value unless |little_endian| is true.
+   */
+  void SetFloat32(size_t byte_offset, float value, bool little_endian = false);
+
+  /**
+   * Set the value at |byte_offset| to |value|. Does nothing if |byte_offset|
+   * is out of range. Writes a big-endian value unless |little_endian| is true.
+   */
+  void SetFloat64(size_t byte_offset, double value, bool little_endian = false);
+
+ private:
+  DataView();
+  static void CheckCast(Value* obj);
+};
+
+
+/**
  * A base class for an instance of TypedArray series of constructors
  * (ES6 draft 15.13.6).
  * This API is experimental and may change significantly.
  */
 class V8EXPORT TypedArray : public Object {
  public:
   /**
    * Returns underlying ArrayBuffer.
    */
   Local<ArrayBuffer> Buffer();
@@ skipping 2833 matching lines @@
   // the implementation of v8.
   static const int kHeapObjectMapOffset = 0;
   static const int kMapInstanceTypeOffset = 1 * kApiPointerSize + kApiIntSize;
   static const int kStringResourceOffset = 3 * kApiPointerSize;
 
   static const int kOddballKindOffset = 3 * kApiPointerSize;
   static const int kForeignAddressOffset = kApiPointerSize;
   static const int kJSObjectHeaderSize = 3 * kApiPointerSize;
   static const int kFixedArrayHeaderSize = 2 * kApiPointerSize;
   static const int kContextHeaderSize = 2 * kApiPointerSize;
-  static const int kContextEmbedderDataIndex = 64;
+  static const int kContextEmbedderDataIndex = 65;
   static const int kFullStringRepresentationMask = 0x07;
   static const int kStringEncodingMask = 0x4;
   static const int kExternalTwoByteRepresentationTag = 0x02;
   static const int kExternalAsciiRepresentationTag = 0x06;
 
   static const int kIsolateStateOffset = 0;
   static const int kIsolateEmbedderDataOffset = 1 * kApiPointerSize;
   static const int kIsolateRootsOffset = 3 * kApiPointerSize;
   static const int kUndefinedValueRootIndex = 5;
   static const int kNullValueRootIndex = 7;
@@ skipping 845 matching lines @@
 
 
 ArrayBuffer* ArrayBuffer::Cast(v8::Value* value) {
 #ifdef V8_ENABLE_CHECKS
   CheckCast(value);
 #endif
   return static_cast<ArrayBuffer*>(value);
 }
 
 
+DataView* DataView::Cast(v8::Value* value) {
+#ifdef V8_ENABLE_CHECKS
+  CheckCast(value);
+#endif
+  return static_cast<DataView*>(value);
+}
+
+
 TypedArray* TypedArray::Cast(v8::Value* value) {
 #ifdef V8_ENABLE_CHECKS
   CheckCast(value);
 #endif
   return static_cast<TypedArray*>(value);
 }
 
 
 Uint8Array* Uint8Array::Cast(v8::Value* value) {
 #ifdef V8_ENABLE_CHECKS
@@ skipping 188 matching lines @@
 
 
 }  // namespace v8
 
 
 #undef V8EXPORT
 #undef TYPE_CHECK
 
 
 #endif  // V8_H_