Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: build/android/pylib/gtest/test_package_executable.py

Issue 15942016: Creates a new test running script test_runner.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/gtest/test_package_executable.py
diff --git a/build/android/pylib/gtest/test_package_executable.py b/build/android/pylib/gtest/test_package_executable.py
index 3e6f6211ed9b95df69782ff6ede0375fbc5fd280..8487733dc8e0ee2090c6d31a21d139a52d2fcfb3 100644
--- a/build/android/pylib/gtest/test_package_executable.py
+++ b/build/android/pylib/gtest/test_package_executable.py
@@ -89,11 +89,11 @@ class TestPackageExecutable(TestPackage):
self.test_suite_basename))
return self._ParseGTestListTests(all_tests)
- def CreateTestRunnerScript(self, gtest_filter, test_arguments):
+ def CreateTestRunnerScript(self, test_filter, test_arguments):
"""Creates a test runner script and pushes to the device.
Args:
- gtest_filter: A gtest_filter flag.
+ test_filter: A test_filter flag.
test_arguments: Additional arguments to pass to the test binary.
"""
tool_wrapper = self.tool.GetTestWrapper()
@@ -102,13 +102,13 @@ class TestPackageExecutable(TestPackage):
# propagate to us.
sh_script_file.write('cd %s\n'
'%s'
- '%s %s/%s --gtest_filter=%s %s\n'
+ '%s %s/%s --test_filter=%s %s\n'
frankf 2013/06/11 02:50:15 Same here.
gkanwar 2013/06/12 01:27:32 Done.
'echo $? > %s' %
(constants.TEST_EXECUTABLE_DIR,
self._AddNativeCoverageExports(),
tool_wrapper, constants.TEST_EXECUTABLE_DIR,
self.test_suite_basename,
- gtest_filter, test_arguments,
+ test_filter, test_arguments,
TestPackageExecutable._TEST_RUNNER_RET_VAL_FILE))
sh_script_file.flush()
cmd_helper.RunCmd(['chmod', '+x', sh_script_file.name])

Powered by Google App Engine
This is Rietveld 408576698