Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1789)

Unified Diff: chrome/browser/gtk/bookmark_manager_gtk.cc

Issue 159419: Correctly update drag status for drags over renderer. This makes things look ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: do what Brett says Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/gtk/bookmark_manager_gtk.cc
===================================================================
--- chrome/browser/gtk/bookmark_manager_gtk.cc (revision 21718)
+++ chrome/browser/gtk/bookmark_manager_gtk.cc (working copy)
@@ -54,6 +54,8 @@
// resizes the column.
const int kDefaultColumnWidth = 200;
+const int kDestTargetList[] = { GtkDndUtil::CHROME_BOOKMARK_ITEM, 0 };
tony 2009/07/27 23:33:03 Nit: Comment?
+
// We only have one manager open at a time.
BookmarkManagerGtk* manager = NULL;
@@ -449,8 +451,7 @@
// The left side is only a drag destination (not a source).
gtk_drag_dest_set(left_tree_view_, GTK_DEST_DEFAULT_DROP,
NULL, 0, GDK_ACTION_MOVE);
- GtkDndUtil::SetDestTargetListFromCodeMask(left_tree_view_,
- GtkDndUtil::CHROME_BOOKMARK_ITEM);
+ GtkDndUtil::SetDestTargetList(left_tree_view_, kDestTargetList);
g_signal_connect(left_tree_view_, "drag-data-received",
G_CALLBACK(&OnLeftTreeViewDragReceived), this);
@@ -525,8 +526,7 @@
GDK_BUTTON1_MASK,
NULL, 0, GDK_ACTION_MOVE);
GtkDndUtil::SetSourceTargetListFromCodeMask(
- right_tree_view_, GtkDndUtil::CHROME_BOOKMARK_ITEM |
- GtkDndUtil::TEXT_URI_LIST);
+ right_tree_view_, kDestTargetList);
// We connect to drag dest signals, but we don't actually enable the widget
// as a drag destination unless it corresponds to the contents of a folder.
@@ -618,8 +618,7 @@
gtk_drag_dest_set(right_tree_view_, GTK_DEST_DEFAULT_ALL, NULL, 0,
GDK_ACTION_MOVE);
- GtkDndUtil::SetDestTargetListFromCodeMask(right_tree_view_,
- GtkDndUtil::CHROME_BOOKMARK_ITEM);
+ GtkDndUtil::SetDestTargetList(right_tree_view_, kDestTargetList);
} else {
SaveColumnConfiguration();
gtk_tree_view_column_set_visible(path_column_, TRUE);

Powered by Google App Engine
This is Rietveld 408576698