Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1517)

Unified Diff: chrome/browser/gtk/bookmark_bar_gtk.h

Issue 159419: Correctly update drag status for drags over renderer. This makes things look ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: do what Brett says Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/gtk/bookmark_bar_gtk.h
===================================================================
--- chrome/browser/gtk/bookmark_bar_gtk.h (revision 21718)
+++ chrome/browser/gtk/bookmark_bar_gtk.h (working copy)
@@ -142,7 +142,7 @@
void PopupMenuForNode(GtkWidget* sender, const BookmarkNode* node,
GdkEventButton* event);
- // GtkButton callbacks
+ // GtkButton callbacks.
static gboolean OnButtonPressed(GtkWidget* sender,
GdkEventButton* event,
BookmarkBarGtk* bar);
@@ -160,18 +160,12 @@
guint target_type, guint time,
BookmarkBarGtk* bar);
- // GtkButton callbacks for folder buttons
+ // GtkButton callbacks for folder buttons.
static gboolean OnFolderButtonReleased(GtkWidget* sender,
GdkEventButton* event,
BookmarkBarGtk* bar);
- static void OnFolderDragReceived(GtkWidget* widget,
- GdkDragContext* context,
- gint x, gint y,
- GtkSelectionData* selection_data,
- guint target_type, guint time,
- BookmarkBarGtk* bar);
- // GtkToolbar callbacks
+ // GtkToolbar callbacks.
static gboolean OnToolbarExpose(GtkWidget* widget, GdkEventExpose* event,
BookmarkBarGtk* window);
static gboolean OnToolbarDragMotion(GtkToolbar* toolbar,
@@ -184,13 +178,15 @@
GdkDragContext* context,
guint time,
BookmarkBarGtk* bar);
- static void OnToolbarDragReceived(GtkWidget* widget,
- GdkDragContext* context,
- gint x, gint y,
- GtkSelectionData* selection_data,
- guint target_type, guint time,
- BookmarkBarGtk* bar);
+ // Used for both folder buttons and the toolbar.
+ static void OnDragReceived(GtkWidget* widget,
+ GdkDragContext* context,
+ gint x, gint y,
+ GtkSelectionData* selection_data,
+ guint target_type, guint time,
+ BookmarkBarGtk* bar);
+
// GtkHBox callbacks.
static gboolean OnHBoxExpose(GtkWidget* widget, GdkEventExpose* event,
BookmarkBarGtk* window);

Powered by Google App Engine
This is Rietveld 408576698