Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 15941025: Add SkData::NewFromFD. (Closed)

Created:
7 years, 6 months ago by bungeman-skia
Modified:
7 years, 6 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add SkData::NewFromFD.

Patch Set 1 #

Patch Set 2 : Remove unneeded include. #

Patch Set 3 : Add tests. #

Patch Set 4 : Remove unrelated change. #

Patch Set 5 : Remove an indentation level. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -204 lines) Patch
M include/core/SkData.h View 1 chunk +10 lines, -0 lines 0 comments Download
M include/core/SkOSFile.h View 1 2 2 chunks +13 lines, -1 line 0 comments Download
M include/core/SkTemplates.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkData.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
D src/ports/SkDebug_brew.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
D src/ports/SkMemory_brew.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
D src/ports/SkOSFile_brew.cpp View 1 chunk +0 lines, -90 lines 0 comments Download
M src/ports/SkOSFile_none.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ports/SkOSFile_posix.cpp View 1 2 3 chunks +23 lines, -6 lines 0 comments Download
M src/ports/SkOSFile_win.cpp View 1 2 3 chunks +23 lines, -9 lines 0 comments Download
M src/utils/win/SkDWriteFontFileStream.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M tests/DataRefTest.cpp View 1 2 3 4 4 chunks +38 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
The motivation for this change is to add SkData::NewFromFD in order to better align with ...
7 years, 6 months ago (2013-05-31 22:32:15 UTC) #1
reed1
Lets create a unittest for this. otherwise lgtm
7 years, 6 months ago (2013-06-03 13:10:34 UTC) #2
bungeman-skia
7 years, 6 months ago (2013-06-03 17:38:37 UTC) #3
Message was sent while issue was closed.
Committed revision 9408.

Powered by Google App Engine
This is Rietveld 408576698