Chromium Code Reviews
Help | Chromium Project | Sign in
(434)

Issue 1594039: Trim whitespace and check for unsafe scheme before adding a url in context me... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by inferno
Modified:
2 years, 11 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews_chromium.org, ben+cc_chromium.org, brettw-cc_chromium.org, lcamtuf
Visibility:
Public.

Description

Trim whitespace and check for unsafe scheme before adding a url in context menu "Go To" item.

BUG=41778
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45062

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Lint Patch
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 3 chunks +10 lines, -3 lines 1 comment 0 errors Download
Commit:

Messages

Total messages: 7
inferno
Peter, can you please review this fix.
4 years ago #1
Peter Kasting
http://codereview.chromium.org/1594039/diff/1/2 File chrome/browser/tab_contents/render_view_context_menu.cc (right): http://codereview.chromium.org/1594039/diff/1/2#newcode447 chrome/browser/tab_contents/render_view_context_menu.cc:447: TrimWhitespace(params_.selection_text, TRIM_ALL, &params_.selection_text); Do this above the check for ...
4 years ago #2
inferno
http://codereview.chromium.org/1594039/diff/1/2 File chrome/browser/tab_contents/render_view_context_menu.cc (right): http://codereview.chromium.org/1594039/diff/1/2#newcode447 chrome/browser/tab_contents/render_view_context_menu.cc:447: TrimWhitespace(params_.selection_text, TRIM_ALL, &params_.selection_text); On 2010/04/17 17:05:09, Peter Kasting wrote: ...
4 years ago #3
Peter Kasting
http://codereview.chromium.org/1594039/diff/1/2 File chrome/browser/tab_contents/render_view_context_menu.cc (right): http://codereview.chromium.org/1594039/diff/1/2#newcode447 chrome/browser/tab_contents/render_view_context_menu.cc:447: TrimWhitespace(params_.selection_text, TRIM_ALL, &params_.selection_text); On 2010/04/17 17:30:40, inferno wrote: > ...
4 years ago #4
inferno
Peter, i misread your previous comment. sorry about that. i fixed the code.
4 years ago #5
Peter Kasting
LGTM. Sorry for the delay, your reply to me got spam-trapped (bad Gmail!), so I ...
4 years ago #6
inferno
4 years ago #7
Thanks Peter. I removed the that blank line before committing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6