Issue 15939005: Add drive::internal::ChangeListProcessorTest.

Issue 15939005: Add drive::internal::ChangeListProcessorTest. (Closed)

Created:
7 years, 6 months ago by kinaba

Modified:
7 years, 6 months ago

Reviewers:
commit-bot: I haz the power, satorux1

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add drive::internal::ChangeListProcessorTest. Not having full coverage yet. Preliminarily adding tests necessary for resolving bug 244316. BUG=147728 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202548

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -0 lines)			Patch
	A	chrome/browser/chromeos/drive/change_list_processor_unittest.cc	View	1	1 chunk	+112 lines, -0 lines	0 comments	Download
	M	chrome/chrome_tests_unit.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

satorux1

LGTM. Nice! https://codereview.chromium.org/15939005/diff/2001/chrome/browser/chromeos/drive/change_list_processor_unittest.cc File chrome/browser/chromeos/drive/change_list_processor_unittest.cc (right): https://codereview.chromium.org/15939005/diff/2001/chrome/browser/chromeos/drive/change_list_processor_unittest.cc#newcode20 chrome/browser/chromeos/drive/change_list_processor_unittest.cc:20: ChangeList* ParseChangeList(const std::string& test_data_path) { function comment ...

7 years, 6 months ago (2013-05-28 07:16:30 UTC) #2

kinaba

https://codereview.chromium.org/15939005/diff/2001/chrome/browser/chromeos/drive/change_list_processor_unittest.cc File chrome/browser/chromeos/drive/change_list_processor_unittest.cc (right): https://codereview.chromium.org/15939005/diff/2001/chrome/browser/chromeos/drive/change_list_processor_unittest.cc#newcode20 chrome/browser/chromeos/drive/change_list_processor_unittest.cc:20: ChangeList* ParseChangeList(const std::string& test_data_path) { On 2013/05/28 07:16:30, satorux1 ...

7 years, 6 months ago (2013-05-28 07:29:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/15939005/11001

7 years, 6 months ago (2013-05-28 07:30:10 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118925

7 years, 6 months ago (2013-05-28 09:41:47 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/15939005/11001

7 years, 6 months ago (2013-05-28 11:38:45 UTC) #6

Message was sent while issue was closed.

Change committed as 202548

Expand Messages | Collapse Messages