Issue 159385: Fixing the google browser name in about:memory page....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159385: Fixing the google browser name in about:memory page.... (Closed)

Created:
11 years, 5 months ago by tfarina (gmail-do not use)

Modified:
9 years, 7 months ago

Reviewers:
kuchhal, dhw

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Fixing the google browser name in about:memory page. BUG=4928 TEST=Open about:memory page a see if the browser name of Google is what is expected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22066

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -11 lines)			Patch
	M	chrome/browser/memory_details.cc	View	1	3 chunks	+15 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tfarina (gmail-do not use)

Rahul, Can you review this to me? I think now it is working as expected. ...

11 years, 5 months ago (2009-07-25 16:00:04 UTC) #1

tfarina (gmail-do not use)

On 2009/07/25 16:00:04, tfarina wrote: > Rahul, > > Can you review this to me? ...

11 years, 4 months ago (2009-07-30 15:10:29 UTC) #2

tfarina (gmail-do not use)

On 2009/07/30 16:04:25, David Wai wrote: > Typo in the bug description section. Should be: ...

11 years, 4 months ago (2009-07-30 16:32:26 UTC) #4

kuchhal

11 years, 4 months ago (2009-07-30 17:35:38 UTC) #5

lgtm.
I will commit it once it clears try bots.

On Thu, Jul 30, 2009 at 9:32 AM, <thiago.farina@gmail.com> wrote:

> On 2009/07/30 16:04:25, David Wai wrote:
>
>> Typo in the bug description section.  Should be: Bug=4928
>>
> Done
>
>
>
> http://codereview.chromium.org/159385
>

Expand Messages | Collapse Messages