Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1593833002: Fix memory overwrite in YUY2ToNV12 odd wdiths (Closed)

Created:
4 years, 11 months ago by fbarchard1
Modified:
4 years, 11 months ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Fix memory overwrite in YUY2ToNV12 odd wdiths When width was odd Y channel wrote an extra pixel. This change splits the Y from UV into a temporary buffer and memcpy's to the destination. Performance is slower. Was YUY2ToNV12_Any (307 ms) YUY2ToNV12_Unaligned (213 ms) TestYUY2ToNV12 (181 ms) YUY2ToNV12_Opt (177 ms) YUY2ToNV12_Invert (177 ms) Npw YUY2ToNV12_Any (300 ms) YUY2ToNV12_Unaligned (226 ms) YUY2ToNV12_Invert (206 ms) TestYUY2ToNV12 (184 ms) YUY2ToNV12_Opt (181 ms) TBR=harryjin@google.com BUG=libyuv:545 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/58cb534962b86fc1b673a8f0835e98852a1754ff

Patch Set 1 #

Patch Set 2 : add note about odd width #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -28 lines) Patch
M README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 1 chunk +1 line, -1 line 0 comments Download
M source/planar_functions.cc View 1 3 chunks +21 lines, -14 lines 0 comments Download
M unit_test/convert_test.cc View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
fbarchard1
4 years, 11 months ago (2016-01-16 03:18:25 UTC) #1
fbarchard1
4 years, 11 months ago (2016-01-19 19:28:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
58cb534962b86fc1b673a8f0835e98852a1754ff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698