Issue 159381: Attempt to fix the ImageOperations::CreateMaskedBitmap UMR by bringing the un...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159381: Attempt to fix the ImageOperations::CreateMaskedBitmap UMR by bringing the un... (Closed)

Created:
11 years, 5 months ago by Glen Murphy

Modified:
9 years, 5 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Attempt to fix the ImageOperations::CreateMaskedBitmap UMR by bringing the unittest code in line with the other tests in image_operations_unittest. My half-educated suspicion is that alpha wasn't getting initted correctly, as a new UMR appeared in the "SkColor alpha_pixel = " line. (Can't verify as all my machines are in boxes). (This is TBR because the build is red). TBR=tony BUG=15762 TEST=Run valgrind/purify as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21610

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
	M	skia/ext/image_operations.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	skia/ext/image_operations_unittest.cc	View		1 chunk	+9 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Glen Murphy

Valgrind says this works, though Purify is stuffed for other reasons.

11 years, 5 months ago (2009-07-25 02:18:58 UTC) #2

LGTM, thanks!

Expand Messages | Collapse Messages