Issue 159380: Software volume control hook-up in linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159380: Software volume control hook-up in linux. (Closed)

Created:
11 years, 5 months ago by awong

Modified:
9 years, 7 months ago

Reviewers:
fbarchard

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Software volume control hook-up in linux. BUG=17709 TEST=None

Patch Set 1 #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	media/audio/linux/alsa_output.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	media/audio/linux/alsa_output.cc	View		4 chunks	+11 lines, -3 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fbarchard

LGTM http://codereview.chromium.org/159380/diff/1/2 File media/audio/linux/alsa_output.cc (right): http://codereview.chromium.org/159380/diff/1/2#newcode529 Line 529: AutoLock l(lock_); is this necessary for one ...

11 years, 5 months ago (2009-07-25 00:57:26 UTC) #2

awong

11 years, 5 months ago (2009-07-25 01:00:52 UTC) #3

On Fri, Jul 24, 2009 at 5:57 PM, <fbarchard@chromium.org> wrote:

> LGTM
>
>
> http://codereview.chromium.org/159380/diff/1/2
> File media/audio/linux/alsa_output.cc (right):
>
> http://codereview.chromium.org/159380/diff/1/2#newcode529
> Line 529: AutoLock l(lock_);
> is this necessary for one variable?


Yes :)  If it's being accessed on multiple threads, it's quite necessary,
no?


>
> http://codereview.chromium.org/159380/diff/1/2#newcode536
> Line 536: *right_level = volume_;
> nit - we should really get rid of this right_level eh.


Yeah...it does suck.

Expand Messages | Collapse Messages