third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl - Issue 1593763002: Keep AudioSourceNode from premature GC with ScriptWrappable::hasPendingActivity()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl

Issue 1593763002: Keep AudioSourceNode from premature GC with ScriptWrappable::hasPendingActivity() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify changes (-AbstractAudioContext) Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/AudioSourceNode.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl

diff --git a/third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl b/third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl

index 0440252f55afb9a5d95652d699d10d05b449428f..b1ed823ce92d376c6f273645996f1e2fda53b441 100644

--- a/third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl

+++ b/third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl

@@ -38,8 +38,8 @@ interface OscillatorNode : AudioSourceNode {

readonly attribute AudioParam frequency; // in Hertz

readonly attribute AudioParam detune; // in Cents

- [RaisesException] void start(optional double when);

- [RaisesException] void stop(optional double when);

+ [RaisesException, ImplementedAs=startNode] void start(optional double when);

+ [RaisesException, ImplementedAs=stopNode] void stop(optional double when);

void setPeriodicWave(PeriodicWave periodicWave);