third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h - Issue 1593763002: Keep AudioSourceNode from premature GC with ScriptWrappable::hasPendingActivity()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h

Issue 1593763002: Keep AudioSourceNode from premature GC with ScriptWrappable::hasPendingActivity() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify changes (-AbstractAudioContext) Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/webaudio/audiosource-premature-gc.html ('K') | « third_party/WebKit/LayoutTests/webaudio/audiosource-premature-gc-expected.txt ('k') | third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h

index d1c085e03aa5568e57338d646041fd6de2bffa44..07ca4190b5ffe8d8508c6f601b1587e54177efb6 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h

@@ -175,10 +175,10 @@ public:

double loopEnd() const;

void setLoopEnd(double);

- void start(ExceptionState&);

- void start(double when, ExceptionState&);

- void start(double when, double grainOffset, ExceptionState&);

- void start(double when, double grainOffset, double grainDuration, ExceptionState&);

+ void startNode(ExceptionState&);

+ void startNode(double when, ExceptionState&);

+ void startNode(double when, double grainOffset, ExceptionState&);

+ void startNode(double when, double grainOffset, double grainDuration, ExceptionState&);

private:

AudioBufferSourceNode(AbstractAudioContext&, float sampleRate);