Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

Issue 1593763002: Keep AudioSourceNode from premature GC with ScriptWrappable::hasPendingActivity() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleaning up test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 class AudioScheduledSourceNode : public AudioSourceNode { 123 class AudioScheduledSourceNode : public AudioSourceNode {
124 public: 124 public:
125 void start(ExceptionState&); 125 void start(ExceptionState&);
126 void start(double when, ExceptionState&); 126 void start(double when, ExceptionState&);
127 void stop(ExceptionState&); 127 void stop(ExceptionState&);
128 void stop(double when, ExceptionState&); 128 void stop(double when, ExceptionState&);
129 129
130 EventListener* onended(); 130 EventListener* onended();
131 void setOnended(PassRefPtrWillBeRawPtr<EventListener>); 131 void setOnended(PassRefPtrWillBeRawPtr<EventListener>);
132 132
133 // ScriptWrappable
134 bool hasPendingActivity() const final;
135
133 protected: 136 protected:
134 explicit AudioScheduledSourceNode(AbstractAudioContext&); 137 explicit AudioScheduledSourceNode(AbstractAudioContext&);
135 AudioScheduledSourceHandler& audioScheduledSourceHandler() const; 138 AudioScheduledSourceHandler& audioScheduledSourceHandler() const;
136 }; 139 };
137 140
138 } // namespace blink 141 } // namespace blink
139 142
140 #endif // AudioScheduledSourceNode_h 143 #endif // AudioScheduledSourceNode_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698