Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1466)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1593713002: MIPS: Refine 'r6 compact branch optimization.' (Closed)

Created:
4 years, 11 months ago by balazs.kilvady
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Refine 'r6 compact branch optimization.' BUG= Committed: https://crrev.com/ccb3181c0b20a792132850e19b32c8ab3486e13d Cr-Commit-Position: refs/heads/master@{#33361}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add DCHECKs, rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M src/mips/assembler-mips.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/mips/constants-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/constants-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/disasm-mips.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/mips/simulator-mips.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
balazs.kilvady
4 years, 11 months ago (2016-01-15 19:24:13 UTC) #2
ivica.bogosavljevic
lgtm https://codereview.chromium.org/1593713002/diff/1/src/mips/disasm-mips.cc File src/mips/disasm-mips.cc (right): https://codereview.chromium.org/1593713002/diff/1/src/mips/disasm-mips.cc#newcode1503 src/mips/disasm-mips.cc:1503: // rs_reg < rt_reg && rs_reg >= 0 ...
4 years, 11 months ago (2016-01-18 10:22:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1593713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1593713002/20001
4 years, 11 months ago (2016-01-18 14:09:24 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-18 14:27:27 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 14:28:28 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ccb3181c0b20a792132850e19b32c8ab3486e13d
Cr-Commit-Position: refs/heads/master@{#33361}

Powered by Google App Engine
This is Rietveld 408576698