Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 159371: Add in UMA logging for context menu playback controls. (Closed)
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/tab_contents/render_view_context_menu.h" 5 #include "chrome/browser/tab_contents/render_view_context_menu.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "base/clipboard.h" 8 #include "base/clipboard.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/scoped_clipboard_writer.h" 11 #include "base/scoped_clipboard_writer.h"
12 #include "chrome/app/chrome_dll_resource.h" 12 #include "chrome/app/chrome_dll_resource.h"
13 #include "chrome/browser/browser_process.h" 13 #include "chrome/browser/browser_process.h"
14 #include "chrome/browser/debugger/devtools_manager.h" 14 #include "chrome/browser/debugger/devtools_manager.h"
15 #include "chrome/browser/download/download_manager.h" 15 #include "chrome/browser/download/download_manager.h"
16 #include "chrome/browser/fonts_languages_window.h" 16 #include "chrome/browser/fonts_languages_window.h"
17 #include "chrome/browser/metrics/user_metrics.h"
17 #include "chrome/browser/page_info_window.h" 18 #include "chrome/browser/page_info_window.h"
18 #include "chrome/browser/profile.h" 19 #include "chrome/browser/profile.h"
19 #include "chrome/browser/search_engines/template_url_model.h" 20 #include "chrome/browser/search_engines/template_url_model.h"
20 #include "chrome/browser/spellchecker.h" 21 #include "chrome/browser/spellchecker.h"
21 #include "chrome/browser/tab_contents/navigation_entry.h" 22 #include "chrome/browser/tab_contents/navigation_entry.h"
22 #include "chrome/browser/tab_contents/tab_contents.h" 23 #include "chrome/browser/tab_contents/tab_contents.h"
23 #include "chrome/common/chrome_switches.h" 24 #include "chrome/common/chrome_switches.h"
24 #include "chrome/common/platform_util.h" 25 #include "chrome/common/platform_util.h"
25 #include "chrome/common/pref_service.h" 26 #include "chrome/common/pref_service.h"
26 #include "chrome/common/url_constants.h" 27 #include "chrome/common/url_constants.h"
(...skipping 506 matching lines...) Expand 10 before | Expand all | Expand 10 after
533 CopyImageAt(params_.x, params_.y); 534 CopyImageAt(params_.x, params_.y);
534 break; 535 break;
535 536
536 case IDS_CONTENT_CONTEXT_OPENAUDIONEWTAB: 537 case IDS_CONTENT_CONTEXT_OPENAUDIONEWTAB:
537 case IDS_CONTENT_CONTEXT_OPENVIDEONEWTAB: 538 case IDS_CONTENT_CONTEXT_OPENVIDEONEWTAB:
538 case IDS_CONTENT_CONTEXT_OPENIMAGENEWTAB: 539 case IDS_CONTENT_CONTEXT_OPENIMAGENEWTAB:
539 OpenURL(params_.src_url, NEW_BACKGROUND_TAB, PageTransition::LINK); 540 OpenURL(params_.src_url, NEW_BACKGROUND_TAB, PageTransition::LINK);
540 break; 541 break;
541 542
542 case IDS_CONTENT_CONTEXT_PLAY: 543 case IDS_CONTENT_CONTEXT_PLAY:
544 UserMetrics::RecordAction(L"MediaContextMenu_Play", profile_);
543 MediaPlayerActionAt(params_.x, 545 MediaPlayerActionAt(params_.x,
544 params_.y, 546 params_.y,
545 MediaPlayerAction(MediaPlayerAction::PLAY)); 547 MediaPlayerAction(MediaPlayerAction::PLAY));
546 break; 548 break;
547 549
548 case IDS_CONTENT_CONTEXT_PAUSE: 550 case IDS_CONTENT_CONTEXT_PAUSE:
551 UserMetrics::RecordAction(L"MediaContextMenu_Pause", profile_);
549 MediaPlayerActionAt(params_.x, 552 MediaPlayerActionAt(params_.x,
550 params_.y, 553 params_.y,
551 MediaPlayerAction(MediaPlayerAction::PAUSE)); 554 MediaPlayerAction(MediaPlayerAction::PAUSE));
552 break; 555 break;
553 556
554 case IDS_CONTENT_CONTEXT_MUTE: 557 case IDS_CONTENT_CONTEXT_MUTE:
558 UserMetrics::RecordAction(L"MediaContextMenu_Mute", profile_);
555 MediaPlayerActionAt(params_.x, 559 MediaPlayerActionAt(params_.x,
556 params_.y, 560 params_.y,
557 MediaPlayerAction(MediaPlayerAction::MUTE)); 561 MediaPlayerAction(MediaPlayerAction::MUTE));
558 break; 562 break;
559 563
560 case IDS_CONTENT_CONTEXT_UNMUTE: 564 case IDS_CONTENT_CONTEXT_UNMUTE:
565 UserMetrics::RecordAction(L"MediaContextMenu_Unmute", profile_);
561 MediaPlayerActionAt(params_.x, 566 MediaPlayerActionAt(params_.x,
562 params_.y, 567 params_.y,
563 MediaPlayerAction(MediaPlayerAction::UNMUTE)); 568 MediaPlayerAction(MediaPlayerAction::UNMUTE));
564 break; 569 break;
565 570
566 case IDS_CONTENT_CONTEXT_LOOP: 571 case IDS_CONTENT_CONTEXT_LOOP:
572 UserMetrics::RecordAction(L"MediaContextMenu_Loop", profile_);
567 if (ItemIsChecked(IDS_CONTENT_CONTEXT_LOOP)) { 573 if (ItemIsChecked(IDS_CONTENT_CONTEXT_LOOP)) {
568 MediaPlayerActionAt(params_.x, 574 MediaPlayerActionAt(params_.x,
569 params_.y, 575 params_.y,
570 MediaPlayerAction(MediaPlayerAction::NO_LOOP)); 576 MediaPlayerAction(MediaPlayerAction::NO_LOOP));
571 } else { 577 } else {
572 MediaPlayerActionAt(params_.x, 578 MediaPlayerActionAt(params_.x,
573 params_.y, 579 params_.y,
574 MediaPlayerAction(MediaPlayerAction::LOOP)); 580 MediaPlayerAction(MediaPlayerAction::LOOP));
575 } 581 }
576 break; 582 break;
577 583
578 case IDS_CONTENT_CONTEXT_PLAYBACKRATE_SLOW: 584 case IDS_CONTENT_CONTEXT_PLAYBACKRATE_SLOW:
585 UserMetrics::RecordAction(L"MediaContextMenu_RateSlow", profile_);
579 MediaPlayerActionAt( 586 MediaPlayerActionAt(
580 params_.x, 587 params_.x,
581 params_.y, 588 params_.y,
582 MediaPlayerAction(MediaPlayerAction::SET_PLAYBACK_RATE, 589 MediaPlayerAction(MediaPlayerAction::SET_PLAYBACK_RATE,
583 kSlowPlaybackRate)); 590 kSlowPlaybackRate));
584 break; 591 break;
585 592
586 case IDS_CONTENT_CONTEXT_PLAYBACKRATE_NORMAL: 593 case IDS_CONTENT_CONTEXT_PLAYBACKRATE_NORMAL:
594 UserMetrics::RecordAction(L"MediaContextMenu_RateNormal", profile_);
587 MediaPlayerActionAt( 595 MediaPlayerActionAt(
588 params_.x, 596 params_.x,
589 params_.y, 597 params_.y,
590 MediaPlayerAction(MediaPlayerAction::SET_PLAYBACK_RATE, 598 MediaPlayerAction(MediaPlayerAction::SET_PLAYBACK_RATE,
591 kNormalPlaybackRate)); 599 kNormalPlaybackRate));
592 break; 600 break;
593 601
594 case IDS_CONTENT_CONTEXT_PLAYBACKRATE_FAST: 602 case IDS_CONTENT_CONTEXT_PLAYBACKRATE_FAST:
603 UserMetrics::RecordAction(L"MediaContextMenu_RateFast", profile_);
595 MediaPlayerActionAt( 604 MediaPlayerActionAt(
596 params_.x, 605 params_.x,
597 params_.y, 606 params_.y,
598 MediaPlayerAction(MediaPlayerAction::SET_PLAYBACK_RATE, 607 MediaPlayerAction(MediaPlayerAction::SET_PLAYBACK_RATE,
599 kFastPlaybackRate)); 608 kFastPlaybackRate));
600 break; 609 break;
601 610
602 case IDS_CONTENT_CONTEXT_PLAYBACKRATE_FASTER: 611 case IDS_CONTENT_CONTEXT_PLAYBACKRATE_FASTER:
612 UserMetrics::RecordAction(L"MediaContextMenu_RateFaster", profile_);
603 MediaPlayerActionAt( 613 MediaPlayerActionAt(
604 params_.x, 614 params_.x,
605 params_.y, 615 params_.y,
606 MediaPlayerAction(MediaPlayerAction::SET_PLAYBACK_RATE, 616 MediaPlayerAction(MediaPlayerAction::SET_PLAYBACK_RATE,
607 kFasterPlaybackRate)); 617 kFasterPlaybackRate));
608 break; 618 break;
609 619
610 case IDS_CONTENT_CONTEXT_PLAYBACKRATE_DOUBLETIME: 620 case IDS_CONTENT_CONTEXT_PLAYBACKRATE_DOUBLETIME:
621 UserMetrics::RecordAction(L"MediaContextMenu_RateDoubleTime", profile_);
611 MediaPlayerActionAt( 622 MediaPlayerActionAt(
612 params_.x, 623 params_.x,
613 params_.y, 624 params_.y,
614 MediaPlayerAction(MediaPlayerAction::SET_PLAYBACK_RATE, 625 MediaPlayerAction(MediaPlayerAction::SET_PLAYBACK_RATE,
615 kDoubleTimePlaybackRate)); 626 kDoubleTimePlaybackRate));
616 break; 627 break;
617 628
618 case IDS_CONTENT_CONTEXT_BACK: 629 case IDS_CONTENT_CONTEXT_BACK:
619 source_tab_contents_->controller().GoBack(); 630 source_tab_contents_->controller().GoBack();
620 break; 631 break;
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
853 WriteTextToClipboard(UTF8ToUTF16(utf8_text)); 864 WriteTextToClipboard(UTF8ToUTF16(utf8_text));
854 DidWriteURLToClipboard(utf8_text); 865 DidWriteURLToClipboard(utf8_text);
855 } 866 }
856 867
857 void RenderViewContextMenu::MediaPlayerActionAt( 868 void RenderViewContextMenu::MediaPlayerActionAt(
858 int x, 869 int x,
859 int y, 870 int y,
860 const MediaPlayerAction& action) { 871 const MediaPlayerAction& action) {
861 source_tab_contents_->render_view_host()->MediaPlayerActionAt(x, y, action); 872 source_tab_contents_->render_view_host()->MediaPlayerActionAt(x, y, action);
862 } 873 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698