This reverts the removal of a Flush that is correlated with file corruption.

This reverts the removal of a Flush that is correlated with file corruption.

Removal of this Flush is correlated with an increase in file
corruption on ChromeOS, so we're going to try and put it
back and see if our file corruption problems get better.

TBR=sky@chromium.org
BUG=chromium:236093
TEST=ran unit tests, ran on device.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203012

[Greg Spencer (Chromium), 2013-05-29 19:34:00]

Scott, I'm looking for an OWNERS review for this.

[sky, 2013-05-29 19:37:06]

From the comments in the thread I thought the corruption was happening in sqlite
files. Is that right? If so, shouldn't the flush be in the sqlite side rather
than here?

[Greg Spencer (Chromium), 2013-05-29 19:58:20]

On 2013/05/29 19:37:06, sky wrote:
> From the comments in the thread I thought the corruption was happening in
sqlite
> files. Is that right? If so, shouldn't the flush be in the sqlite side rather
> than here?

Yes, I agree, but finding the appropriate place to do that in SQLite without
adverse consequences elsewhere is going to take a while.  We know that this
change is correlated with an increase in corruption of the SQLite databases, and
we know that it's safe to do, since the code was like this for almost two years
with no problems.  The TPMs and Zel and I are eager to get something into the
current releases that will help stabilize this problem without making things
worse, and this is one change we feel we can make that will move in that
direction.

[sky, 2013-05-29 20:24:29]

LGTM - as long as you come back to this and remove it since it's a hack to place
the commit here.

[Greg Spencer (Chromium), 2013-05-29 20:28:21]

On 2013/05/29 20:24:29, sky wrote:
> LGTM - as long as you come back to this and remove it since it's a hack to
place
> the commit here.

OK, I'll add a TODO and file an issue to that effect.

[commit-bot: I haz the power, 2013-05-29 20:41:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/15937015/6002

[Greg Spencer (Chromium), 2013-05-30 00:07:38]

Committed patchset #2 manually as r203012 (presubmit successful).