Land Recent QUIC changes.

Land Recent QUIC changes.

Make the FEC group optional by adding a flag to the private headers.

Merge internal change: 46979143

Merging changes from chromium CL - 15385004

Merge internal change: 46949614

Removing debug logging from RecordPacketReceived.  Seems redundant to
log both when we actually receive and when we record it.

Merge internal change: 46934210

Logging crypto handshake as a DVLOG rather than DLOG as it hasn't
recently been needed to debug test failures.

Merge internal change: 46932247

Changing the quic test client to simply not return a stream if not connected.

This will hopefully turn server test check-failures into server test
failures.

Merge internal change: 46932163

QUIC: redo server nonces.

Previously, in order to cope with strike-register failures and client
clock-sync issues, the server could issue a server nonce to a client. This
meant that the server had to remember rejected handshakes so that the server
nonce could be matched up. With this change, QUIC servers no longer need to
keep track of rejected handshakes.

Instead of issuing and remembering nonces, a server will now encrypt them and
forget about them. When a server nonce is used to establish freshness for a
connection, it will be stored in a per-GFE strike-register. (This
strike-register is separate from the one used to process client nonces.)

Merge internal change: 46889484

Remove FEC_ENTROPY_FLAG from private flags. Now, FEC packet's entropy
flag contain the xor of entropies of the protected packets.

Merge internal change: 46889094

Limit the number of times we'll fast-retransmit a given packet using taildrop.

Merge internal change: 46754530

Added CommonCertSetsQUIC to anonymous namespace.


QUIC: cleanups round two.

 * Make CommonCertSetsQUIC a Singleton to save on every Config having its own
   copy.
 * Rework server config expiry: previously it caused an error at client hello
   send time. Now it will cause an error at REJ processing time but, if the
   config expired after we cached it, we will act as if we didn't have a cached
   server config.
 * Invalidate the server config cache in the event of a client hello sending
   failure. This will prevent a bad server config from being cached and poisoning
   connection attempts for the lifetime of the cache.
 * Fix a bug in the test code which failed to parse hex chunks in debugging
   messages correctly. (Thanks to wtc for noticing.)

Merge internal change: 46742937

Merging changes from chromium - CL 15074007

Merge internal change: 46710932

Fix a bug in QuicSession's header compression behavior which could lead
to infinite loops.

Merge internal change: 46694681

Getting 5% our CPU usage back by not calculating SentBandwidth for the
tcp congestion control algorithm.

Added a TODO to improve that function since it's pretty abysmal: the
ToLargerUnits and Subtract overhead alone accounted for 4.5% of the cpu
in initial loadtest runs.

Merge internal change: 46608880

Adding support for truncated guids in QuicFramer.

Merge internal change: 46575819

using our latched write_blocked status to spare us useless system calls.

Merge internal change: 46573462

Fixing some crashing issues in the QUIC loadtest, where if a client ever
disconnects it never recovers, either crashing trying to create a stream
or crashing waiting for a response on a non-existant stream.

I'm not sure if we have the same problem for the http/https simple clients
but we definitely do for QUIC.

Merge internal change: 46562890

Merging changes from chromium - CL 14614006

Merge internal change: 46460427

Merging cleanup changes from chromium CL - 14651009

Merge internal change: 46457093

Fixing a test framework bug for quic: we were munging headers to do
https:// for insecure quic resulting in a 404 in the http-only service
map. Then disalbing the test since we don't advertise secure SPDY on
insecure QUIC.

Merge internal change: 46408400

Move QuicConfig from ssl_global_data to quic_dispatcher.cc. Initialize
using values from QuicConfigProto and use the max_time_before_crypto_handshake
to set the overall connection timeout before crypto handshake finishes.

Merge internal change: 46400649

QUIC: implement ChannelIDs.

We'll need this for HTTPS.

Merge internal change: 46396357

Deleted usage of scoped_ptr_openssl. Added TODO comments for porting
ChannelIDSigner and Verifier.

R=rch@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203220

[ramant (doing other things), 2013-05-30 03:17:28]

Fixed Valgrind errors with initialization. Ran by agl changes to
strike_register_test.cc. Fixed the OpenSSL compilation fixes. Please take a look
at the patchset#2.

thanks
raman

[Ryan Hamilton, 2013-05-30 18:08:50]

LGTM since I have reviewed all the constituent changes.

[commit-bot: I haz the power, 2013-05-30 18:10:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/15937012/58001

[commit-bot: I haz the power, 2013-05-30 21:12:23]

Change committed as 203220

[wtc, 2013-06-03 17:24:00]

Patch set 2 LGTM. I only reviewed the diffs between patch
sets 1 and 2.

https://codereview.chromium.org/15937012/diff/58001/net/quic/crypto/strike_re...
File net/quic/crypto/strike_register_test.cc (right):

https://codereview.chromium.org/15937012/diff/58001/net/quic/crypto/strike_re...
net/quic/crypto/strike_register_test.cc:22: NonceSetTimeAndOrbit(uint8
nonce[32], unsigned time, const uint8 orbit[8]) {

It is a little surprising that a function named
"set time and orbit" also overwrites the random bytes in the
nonce.

I understand it is convenient to initialize the random bytes
in this function. How about renaming this function SetNonce
and adding a comment to explain that these strike register
tests don't look at the random bytes so this function can
simply set the random bytes to 0?

https://codereview.chromium.org/15937012/diff/58001/net/quic/test_tools/crypt...
File net/quic/test_tools/crypto_test_utils_openssl.cc (right):

https://codereview.chromium.org/15937012/diff/58001/net/quic/test_tools/crypt...
net/quic/test_tools/crypto_test_utils_openssl.cc:24:
(void)EVP_MD_CTX_cleanup(ctx);

Nit: on the previous line, the asterisk '*' should be placed
next to the type.

Just curious: did you add this (void) cast on my suggestion,
or did some tool or compiler warn that we're not checking
the return value?

[ramant (doing other things), 2013-06-14 03:26:16]

https://codereview.chromium.org/15937012/diff/58001/net/quic/crypto/strike_re...
File net/quic/crypto/strike_register_test.cc (right):

https://codereview.chromium.org/15937012/diff/58001/net/quic/crypto/strike_re...
net/quic/crypto/strike_register_test.cc:22: NonceSetTimeAndOrbit(uint8
nonce[32], unsigned time, const uint8 orbit[8]) {
On 2013/06/03 17:24:00, wtc wrote:
> 
> It is a little surprising that a function named
> "set time and orbit" also overwrites the random bytes in the
> nonce.
> 
> I understand it is convenient to initialize the random bytes
> in this function. How about renaming this function SetNonce
> and adding a comment to explain that these strike register
> tests don't look at the random bytes so this function can
> simply set the random bytes to 0?

Fixed in CL: https://codereview.chromium.org/17040003
Done.

https://codereview.chromium.org/15937012/diff/58001/net/quic/test_tools/crypt...
File net/quic/test_tools/crypto_test_utils_openssl.cc (right):

https://codereview.chromium.org/15937012/diff/58001/net/quic/test_tools/crypt...
net/quic/test_tools/crypto_test_utils_openssl.cc:24:
(void)EVP_MD_CTX_cleanup(ctx);
On 2013/06/03 17:24:00, wtc wrote:
> 
> Nit: on the previous line, the asterisk '*' should be placed
> next to the type.

Fixed in CL https://codereview.chromium.org/17040003

> 
> Just curious: did you add this (void) cast on my suggestion,
> or did some tool or compiler warn that we're not checking
> the return value?

Added the cast on your suggestion. There were no compiler warnings.