Unify ActivateCellular into network_connect.cc

Unify ActivateCellular into network_connect.cc

BUG=242285
For ash delegate
TBR=jamescook@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202807

[stevenjb, 2013-05-24 19:45:48]

This should move all of the activation logic to one place, and out of other code
modules so that they can be migrated to use NetworkHandler before the activation
logic is migrated.

[tbarzic, 2013-05-24 21:24:34]

https://codereview.chromium.org/15937008/diff/1/chrome/browser/chromeos/optio...
File chrome/browser/chromeos/options/network_connect.cc (right):

https://codereview.chromium.org/15937008/diff/1/chrome/browser/chromeos/optio...
chrome/browser/chromeos/options/network_connect.cc:82: network = cros->
FindNetworkByPath(service_path);
FindCellularNetworkByPath? That way you don't have to check network type or use
cast. Also, I'd merge this with the previous line.

+ remove extra space after ->

https://codereview.chromium.org/15937008/diff/1/chrome/browser/chromeos/optio...
File chrome/browser/chromeos/options/network_connect.h (right):

https://codereview.chromium.org/15937008/diff/1/chrome/browser/chromeos/optio...
chrome/browser/chromeos/options/network_connect.h:26: // * Activation for non
dircect-activation networks
nit: dot at the sentence end.
s/dircect/direct

[stevenjb, 2013-05-24 22:17:45]

https://codereview.chromium.org/15937008/diff/1/chrome/browser/chromeos/optio...
File chrome/browser/chromeos/options/network_connect.cc (right):

https://codereview.chromium.org/15937008/diff/1/chrome/browser/chromeos/optio...
chrome/browser/chromeos/options/network_connect.cc:82: network = cros->
FindNetworkByPath(service_path);
On 2013/05/24 21:24:34, tbarzic wrote:
> FindCellularNetworkByPath? That way you don't have to check network type or
use
> cast. Also, I'd merge this with the previous line.
> 
> + remove extra space after ->
Yes, done (copy/pasted old code).

https://codereview.chromium.org/15937008/diff/1/chrome/browser/chromeos/optio...
File chrome/browser/chromeos/options/network_connect.h (right):

https://codereview.chromium.org/15937008/diff/1/chrome/browser/chromeos/optio...
chrome/browser/chromeos/options/network_connect.h:26: // * Activation for non
dircect-activation networks
On 2013/05/24 21:24:34, tbarzic wrote:
> nit: dot at the sentence end.
> s/dircect/direct
Not sentences (phrases). Fixed typo.

[tbarzic, 2013-05-24 22:40:03]

lgtm

https://codereview.chromium.org/15937008/diff/1/chrome/browser/chromeos/optio...
File chrome/browser/chromeos/options/network_connect.h (right):

https://codereview.chromium.org/15937008/diff/1/chrome/browser/chromeos/optio...
chrome/browser/chromeos/options/network_connect.h:26: // * Activation for non
dircect-activation networks
On 2013/05/24 22:17:45, stevenjb (chromium) wrote:
> On 2013/05/24 21:24:34, tbarzic wrote:
> > nit: dot at the sentence end.
> > s/dircect/direct
> Not sentences (phrases). Fixed typo.
> 

oh, yeah.. sorry :)

https://codereview.chromium.org/15937008/diff/6001/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/15937008/diff/6001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:1649: 
The behaviour when direct activation is not used has changed.
I think calling UpdateConnectionData should be safe, but the comment should
probably be changed.

[commit-bot: I haz the power, 2013-05-28 18:15:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/15937008/35001

[commit-bot: I haz the power, 2013-05-28 18:36:05]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-05-28 19:17:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/15937008/41001

[commit-bot: I haz the power, 2013-05-28 19:28:44]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-05-28 22:55:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/15937008/46001

[commit-bot: I haz the power, 2013-05-28 23:04:32]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-05-28 23:17:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/15937008/46001

[commit-bot: I haz the power, 2013-05-29 07:55:36]

Change committed as 202807