Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2612)

Unified Diff: chrome/browser/extensions/scoped_gaia_auth_extension.cc

Issue 15937003: Change loading custom auth extension to load from --auth-ext-path value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/scoped_gaia_auth_extension.cc
diff --git a/chrome/browser/extensions/scoped_gaia_auth_extension.cc b/chrome/browser/extensions/scoped_gaia_auth_extension.cc
index 03e5e72f7a83c17fac4fad90592a33f473e70e2f..7ad98ea8997f2f8ba6baf8c4cbd692674f490a49 100644
--- a/chrome/browser/extensions/scoped_gaia_auth_extension.cc
+++ b/chrome/browser/extensions/scoped_gaia_auth_extension.cc
@@ -34,7 +34,12 @@ void LoadGaiaAuthExtension(Profile* profile) {
if (command_line->HasSwitch(switches::kAuthExtensionPath)) {
base::FilePath auth_extension_path =
command_line->GetSwitchValuePath(switches::kAuthExtensionPath);
- component_loader->Add(IDR_GAIA_TEST_AUTH_MANIFEST, auth_extension_path);
+ std::string extension_id =
achuithb 2013/05/23 22:34:47 let's make this const
Tim Song 2013/05/23 23:07:05 Done.
+ component_loader->AddOrReplace(auth_extension_path);
+
+ if (extension_id.empty())
+ LOG(ERROR) << "Failed to load custom Gaia auth extension given by "
+ << "--auth-ext-path flag: " << auth_extension_path.value();
achuithb 2013/05/23 22:34:47 nit: let's use switches::kAuthExtensionPath instea
Tim Song 2013/05/23 23:07:05 Done.
return;
}

Powered by Google App Engine
This is Rietveld 408576698