Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1593603002: MIPS: [runtime] Throw exception for derived constructors in correct context. (Closed)

Created:
4 years, 11 months ago by balazs.kilvady
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [runtime] Throw exception for derived constructors in correct context. Port for https://codereview.chromium.org/1593553002/ Original commit message: When derived constructors return a non-object (or not undefined) we currently throw an exception directly in the callee context. This was achieved by desugaring the return statement for derived classes. To be spec compliamnt a separate ConstructStubForDerived is introduced. Instead of trowing directly, the desugared return statement inside a derived constructor only returns an integer to indicate an incompatible result. BUG=v8:4509 LOG=n Committed: https://crrev.com/316ef286765deab3079d8dda4853da9c5dc842d4 Cr-Commit-Position: refs/heads/master@{#33340}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Drop push()es. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -10 lines) Patch
M src/mips/builtins-mips.cc View 1 3 chunks +19 lines, -5 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 3 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
balazs.kilvady
4 years, 11 months ago (2016-01-15 13:21:31 UTC) #2
Camillo Bruni
https://codereview.chromium.org/1593603002/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/1593603002/diff/1/src/mips/builtins-mips.cc#newcode696 src/mips/builtins-mips.cc:696: __ push(v0); Sorry, I figured out that I don't ...
4 years, 11 months ago (2016-01-15 13:51:47 UTC) #3
balazs.kilvady
https://codereview.chromium.org/1593603002/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/1593603002/diff/1/src/mips/builtins-mips.cc#newcode696 src/mips/builtins-mips.cc:696: __ push(v0); On 2016/01/15 13:51:47, cbruni wrote: > Sorry, ...
4 years, 11 months ago (2016-01-15 13:59:44 UTC) #4
Camillo Bruni
lgtm
4 years, 11 months ago (2016-01-15 15:33:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1593603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1593603002/20001
4 years, 11 months ago (2016-01-15 16:37:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 16:57:56 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 16:58:50 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/316ef286765deab3079d8dda4853da9c5dc842d4
Cr-Commit-Position: refs/heads/master@{#33340}

Powered by Google App Engine
This is Rietveld 408576698