Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 1593583002: [heap] Remove store_buffer_counter from MemoryChunk (Closed)

Created:
4 years, 11 months ago by Michael Lippautz
Modified:
4 years, 11 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove store_buffer_counter from MemoryChunk It is only used locally when exempting pages from the store buffer. This use case can be replaced with a hashmap at the call site. BUG=chromium:524425 LOG=N R=ulan@chromium.org Committed: https://crrev.com/a89d41f05b523a557152969f0f5c4625af0c8c16 Cr-Commit-Position: refs/heads/master@{#33324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
M src/heap/spaces.h View 5 chunks +5 lines, -14 lines 0 comments Download
M src/heap/store-buffer.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1593583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1593583002/1
4 years, 11 months ago (2016-01-15 11:00:45 UTC) #2
Michael Lippautz
PTAL, this is the part that removes the store_buffer_counter field on our MemoryChunk. The case ...
4 years, 11 months ago (2016-01-15 11:01:44 UTC) #3
ulan
lgtm
4 years, 11 months ago (2016-01-15 11:44:23 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-15 11:45:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1593583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1593583002/1
4 years, 11 months ago (2016-01-15 11:48:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 11:49:53 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 11:50:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a89d41f05b523a557152969f0f5c4625af0c8c16
Cr-Commit-Position: refs/heads/master@{#33324}

Powered by Google App Engine
This is Rietveld 408576698