[runtime] Throw exception for derived constructors in correct context.

[runtime] Throw exception for derived constructors in correct context.

When derived constructors return a non-object (or not undefined) we
currently throw an exception directly in the callee context. This was
achieved by desugaring the return statement for derived classes. To
be spec compliamnt a separate ConstructStubForDerived is introduced.
Instead of trowing directly, the desugared return statement inside
a derived constructor only returns an integer to indicate an incompatible
result.

BUG=v8:4509
LOG=n

Committed: https://crrev.com/c86f1897ac52f2cae088d6cab8843216bdaa9396
Cr-Commit-Position: refs/heads/master@{#33336}

[Camillo Bruni, 2016-01-15 10:28:03]

Description was changed from

==========
[runtime] Throw exception for derived constructors in correct context.

When derived constructors return a non-object (or not undefined) we
currently throw an exception directly in the callee context. This was
achieved by desugaring the return statement for derived classes. To
be spec compliamnt a separate ConstructStubForDerived is introduced.
Instead of trowing directly, the desugared return statement inside
a derived constructor only returns an integer to indicate an incompatible
result.

BUG=v8:4509
==========

to

==========
[runtime] Throw exception for derived constructors in correct context.

When derived constructors return a non-object (or not undefined) we
currently throw an exception directly in the callee context. This was
achieved by desugaring the return statement for derived classes. To
be spec compliamnt a separate ConstructStubForDerived is introduced.
Instead of trowing directly, the desugared return statement inside
a derived constructor only returns an integer to indicate an incompatible
result.

BUG=v8:4509
LOG=n
==========

[Camillo Bruni, 2016-01-15 10:28:45]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-15 10:28:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1593553002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1593553002/1

[Camillo Bruni, 2016-01-15 10:34:03]

cbruni@chromium.org changed reviewers:
+ bmeurer@chromium.org, verwaest@chromium.org

[Camillo Bruni, 2016-01-15 10:34:04]

PTAL

mips-team, ppc-team: Please port this CL, thanks.

[commit-bot: I haz the power, 2016-01-15 10:43:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-15 10:43:44]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/14129)

[Benedikt Meurer, 2016-01-15 10:47:01]

LGTM.

[Camillo Bruni, 2016-01-15 10:49:55]

cbruni@chromium.org changed reviewers:
+ rossberg@chromium.org

[Camillo Bruni, 2016-01-15 10:49:56]

rossberg: could you check the changes in parsing/*? thanks.

[rossberg, 2016-01-15 11:02:47]

Parser changes LGTM up to nits.

https://codereview.chromium.org/1593553002/diff/20001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1593553002/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:2728: // and throw an exception in case of a non object.
Update this comment.

https://codereview.chromium.org/1593553002/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:2736: // temp = expr
Nit: Insert an empty line before this one.

[balazs.kilvady, 2016-01-15 11:09:01]

We are working on the MIPS port.

[Camillo Bruni, 2016-01-15 11:38:25]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-15 11:38:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1593553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1593553002/40001

[commit-bot: I haz the power, 2016-01-15 11:51:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-15 11:51:44]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[balazs.kilvady, 2016-01-15 13:23:24]

Please find the MIPS port at: https://codereview.chromium.org/1593603002/

[Camillo Bruni, 2016-01-15 13:49:44]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-15 13:49:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1593553002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1593553002/60001

[commit-bot: I haz the power, 2016-01-15 14:05:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-15 14:05:41]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/14156)

[Camillo Bruni, 2016-01-15 14:13:26]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-01-15 14:13:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1593553002/#ps80001
(title: "update runtime function args length dcheck")

[commit-bot: I haz the power, 2016-01-15 14:13:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1593553002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1593553002/80001

[commit-bot: I haz the power, 2016-01-15 14:43:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-15 14:43:34]

Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/12458)

[Camillo Bruni, 2016-01-15 15:10:01]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-01-15 15:10:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1593553002/#ps100001
(title: "disable regression test for ignition")

[commit-bot: I haz the power, 2016-01-15 15:10:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1593553002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1593553002/100001

[commit-bot: I haz the power, 2016-01-15 15:31:05]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-01-15 15:31:36]

Description was changed from

==========
[runtime] Throw exception for derived constructors in correct context.

When derived constructors return a non-object (or not undefined) we
currently throw an exception directly in the callee context. This was
achieved by desugaring the return statement for derived classes. To
be spec compliamnt a separate ConstructStubForDerived is introduced.
Instead of trowing directly, the desugared return statement inside
a derived constructor only returns an integer to indicate an incompatible
result.

BUG=v8:4509
LOG=n
==========

to

==========
[runtime] Throw exception for derived constructors in correct context.

When derived constructors return a non-object (or not undefined) we
currently throw an exception directly in the callee context. This was
achieved by desugaring the return statement for derived classes. To
be spec compliamnt a separate ConstructStubForDerived is introduced.
Instead of trowing directly, the desugared return statement inside
a derived constructor only returns an integer to indicate an incompatible
result.

BUG=v8:4509
LOG=n

Committed: https://crrev.com/c86f1897ac52f2cae088d6cab8843216bdaa9396
Cr-Commit-Position: refs/heads/master@{#33336}
==========

[commit-bot: I haz the power, 2016-01-15 15:31:37]

Patchset 6 (id:??) landed as
https://crrev.com/c86f1897ac52f2cae088d6cab8843216bdaa9396
Cr-Commit-Position: refs/heads/master@{#33336}