content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java - Issue 1593533002: Trigger compositionstart/end on commitText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java

Issue 1593533002: Trigger compositionstart/end on commitText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change commitText instead Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('k') | content/test/data/android/ime/input_forms.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java

diff --git a/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java b/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java

index d5e5485729cec1ed52406b661f2cd4c81f2b194b..75ad2fe4b4a5b24baa3b176e5864317c8979e5b4 100644

--- a/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java

+++ b/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java

@@ -74,8 +74,9 @@ public class ContentShellTestBase

* Starts the content shell activity with the provided test url.

* The url is synchronously loaded.

* @param url Test url to load.

+ * @throws InterruptedException

- protected void startActivityWithTestUrl(String url) throws Throwable {

+ protected void startActivityWithTestUrl(String url) throws InterruptedException {

launchContentShellWithUrl(UrlUtils.getIsolatedTestFileUrl(url));

assertNotNull(getActivity());

waitForActiveShellToBeDoneLoading();

@@ -203,6 +204,7 @@ public class ContentShellTestBase

CriteriaHelper.pollForCriteria(new Criteria() {

@Override

public boolean isSatisfied() {

+ updateFailureReason(Float.toString(getContentViewCore().getScale()));

return getContentViewCore().getScale() == expectedScale;

}

});