Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 159353003: Harmony: fix spec violation in Math.cosh. (Closed)

Created:
6 years, 10 months ago by Yang
Modified:
6 years, 10 months ago
Reviewers:
Sven Panne, Jarin
CC:
v8-dev
Visibility:
Public.

Description

Harmony: fix spec violation in Math.cosh. R=jarin@chromium.org BUG=v8:3141 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19272

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed outdated comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/harmony-math.js View 1 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/harmony/math-hyperbolic.js View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
6 years, 10 months ago (2014-02-11 10:51:45 UTC) #1
Sven Panne
DBC https://codereview.chromium.org/159353003/diff/1/src/harmony-math.js File src/harmony-math.js (right): https://codereview.chromium.org/159353003/diff/1/src/harmony-math.js#newcode62 src/harmony-math.js:62: // Idempotent for NaN and +/-Infinity. Nit: The ...
6 years, 10 months ago (2014-02-11 11:33:49 UTC) #2
Yang
On 2014/02/11 11:33:49, Sven Panne wrote: > DBC > > https://codereview.chromium.org/159353003/diff/1/src/harmony-math.js > File src/harmony-math.js (right): ...
6 years, 10 months ago (2014-02-11 11:35:29 UTC) #3
Jarin
On 2014/02/11 11:35:29, Yang wrote: > On 2014/02/11 11:33:49, Sven Panne wrote: > > DBC ...
6 years, 10 months ago (2014-02-11 11:47:17 UTC) #4
Yang
6 years, 10 months ago (2014-02-11 11:48:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r19272 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698