This CL adds methods to manipulate RTP header extension, particularly

content/browser/renderer_host/p2p/socket_host.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_H_
 #define CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_H_
 
 #include "content/common/content_export.h"
 #include "content/public/common/p2p_socket_type.h"
 #include "net/base/ip_endpoint.h"
@@ skipping 31 matching lines @@
                     const std::vector<char>& data,
                     net::DiffServCodePoint dscp,
                     uint64 packet_id) = 0;
 
   virtual P2PSocketHost* AcceptIncomingTcpConnection(
       const net::IPEndPoint& remote_address, int id) = 0;
 
   virtual bool SetOption(P2PSocketOption option, int value) = 0;
 
  protected:
+  void MaybeUpdateRtpSendTimeExtn(const char* data, int len);

[juberti2, 2014/02/14 01:53:27]

The naming could be clearer here - you have 3 functions that do similar things
with different (and slightly confusing) names:
MaybeURSTE works on an arbitrary packet
ParseRtpPacket works on a RTP packet
UpdateRtpSendTimeExtn works on the extension

suggest having a more unified set of names, like
MaybeUpdatePacketSendTime
MaybeUpdateRtpSendTime
UpdateRtpExtnSendTime
UpdateRtpAuthTag

[Solis, 2014/02/14 10:05:29]

I assume you mean to update the absolute sender time extension, if present.
Change name to

MaybeUpdateAbsSendTimeExtn() or
MaybeUpdateAbsoluteSenderTimeExtension()

Not sure whether the "Rtp" part is necessary or not. Maybe you could pull all
these functions into a utility namespace?

+
   friend class P2PSocketHostTcpTestBase;
 
   // TODO(mallinath) - Remove this below enum and use one defined in
   // libjingle/souce/talk/p2p/base/stun.h
   enum StunMessageType {
     STUN_BINDING_REQUEST = 0x0001,
     STUN_BINDING_RESPONSE = 0x0101,
     STUN_BINDING_ERROR_RESPONSE = 0x0111,
     STUN_SHARED_SECRET_REQUEST = 0x0002,
     STUN_SHARED_SECRET_RESPONSE = 0x0102,
@@ skipping 24 matching lines @@
   };
 
   P2PSocketHost(IPC::Sender* message_sender, int id);
 
   // Verifies that the packet |data| has a valid STUN header. In case
   // of success stores type of the message in |type|.
   static bool GetStunPacketType(const char* data, int data_size,
                                 StunMessageType* type);
   static bool IsRequestOrResponse(StunMessageType type);
 
+  bool ParseRtpPacket(const char* data, int len);

[Solis, 2014/02/14 10:05:29]

I think you can remove these functions from the class - see comment in .cc.

+  int SkipPaddingBytes(const char* data, int len);
+  void UpdateRtpSendTimeExtn(const char* data, int len);
+
+  void UpdateHmac(const void* packet, int len);
+
   IPC::Sender* message_sender_;
   int id_;
   State state_;
+  int rtp_sendtime_extn_id_;
 
   DISALLOW_COPY_AND_ASSIGN(P2PSocketHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_H_