This CL adds methods to manipulate RTP header extension, particularly

content/browser/renderer_host/p2p/socket_host.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_H_
 #define CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_H_
 
 #include "content/common/content_export.h"
 #include "content/public/common/p2p_socket_type.h"
 #include "net/base/ip_endpoint.h"
 #include "net/udp/datagram_socket.h"
 
 namespace IPC {
 class Sender;
 }
 
 namespace net {
 class URLRequestContextGetter;
 }
 
 namespace talk_base {
 struct PacketOptions;
 }
 
 namespace content {
 class P2PMessageThrottler;
 
+
+// Helper methods for processing a packet.

[Solis, 2014/02/27 09:36:10]

put these in a nested namespace:

namespace packet_processing_helpers {

obviating the need for a comment.

[Mallinath (Gone from Chromium), 2014/02/27 19:43:10]

Done.

+bool GetRtpPacketStartPositionAndLength(char* data, int length,

[Solis, 2014/02/27 09:36:10]

Only GetRtpPacketStartPositionAndLength() and MaybeUpdatePacketAbsSendTimeExtn()
need to be exposed at this level. The others should be private helpers in the
.cc.

[Mallinath (Gone from Chromium), 2014/02/27 19:43:10]

Done.

+                                        int* rtp_start_pos,
+                                        int* rtp_packet_length);
+bool ValidateRtpHeader(char* rtp, int length);
+
+void MaybeUpdatePacketAbsSendTimeExtn(char* data, int length,
+                                      const talk_base::PacketOptions& options);
+bool MaybeUpdateRtpAbsSendTimeExtn(char* rtp, int length,
+                                int extension_id);
+void UpdateAbsSendTimeExtnValue(char* data, int len);
+
+void MaybeUpdateRtpAuthTag(char* packet, int len,
+                           const talk_base::PacketOptions& options);
+
 // Base class for P2P sockets.
 class CONTENT_EXPORT P2PSocketHost {
  public:
   static const int kStunHeaderSize = 20;
   // Creates P2PSocketHost of the specific type.
   static P2PSocketHost* Create(IPC::Sender* message_sender,
                                int id, P2PSocketType type,
                                net::URLRequestContextGetter* url_context,
                                P2PMessageThrottler* throttler);
 
   virtual ~P2PSocketHost();
 
   // Initalizes the socket. Returns false when initiazations fails.
   virtual bool Init(const net::IPEndPoint& local_address,
                     const net::IPEndPoint& remote_address) = 0;
 
   // Sends |data| on the socket to |to|.
   virtual void Send(const net::IPEndPoint& to,
                     const std::vector<char>& data,
                     const talk_base::PacketOptions& options,
                     uint64 packet_id) = 0;
 
   virtual P2PSocketHost* AcceptIncomingTcpConnection(
       const net::IPEndPoint& remote_address, int id) = 0;
 
   virtual bool SetOption(P2PSocketOption option, int value) = 0;
 
  protected:
-  friend class P2PSocketHostTcpTestBase;
 
   // TODO(mallinath) - Remove this below enum and use one defined in
   // libjingle/souce/talk/p2p/base/stun.h
   enum StunMessageType {
     STUN_BINDING_REQUEST = 0x0001,
     STUN_BINDING_RESPONSE = 0x0101,
     STUN_BINDING_ERROR_RESPONSE = 0x0111,
     STUN_SHARED_SECRET_REQUEST = 0x0002,
     STUN_SHARED_SECRET_RESPONSE = 0x0102,
     STUN_SHARED_SECRET_ERROR_RESPONSE = 0x0112,
@@ skipping 33 matching lines @@
   IPC::Sender* message_sender_;
   int id_;
   State state_;
 
   DISALLOW_COPY_AND_ASSIGN(P2PSocketHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_H_