This CL adds methods to manipulate RTP header extension, particularly

content/browser/renderer_host/p2p/socket_host.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_H_
 #define CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_H_
 
 #include "content/common/content_export.h"
 #include "content/public/common/p2p_socket_type.h"
 #include "net/base/ip_endpoint.h"
@@ skipping 35 matching lines @@
                     const std::vector<char>& data,
                     const talk_base::PacketOptions& options,
                     uint64 packet_id) = 0;
 
   virtual P2PSocketHost* AcceptIncomingTcpConnection(
       const net::IPEndPoint& remote_address, int id) = 0;
 
   virtual bool SetOption(P2PSocketOption option, int value) = 0;
 
  protected:
-  friend class P2PSocketHostTcpTestBase;
+
+  void MaybeUpdatePacketSendTimeExtn(char* data, int length,

[Solis, 2014/02/26 15:49:34]

AFAICT none of the methods you've added need to access state in the class.
Therefore they should be pulled out from the class and into a namespace instead
(or at the very least be made static). By doing so there would be no need to
subclass P2PSocketHost in the test.

[Mallinath (Gone from Chromium), 2014/02/26 19:59:20]

That's a good point.

+                                     const talk_base::PacketOptions& options);
 
   // TODO(mallinath) - Remove this below enum and use one defined in
   // libjingle/souce/talk/p2p/base/stun.h
   enum StunMessageType {
     STUN_BINDING_REQUEST = 0x0001,
     STUN_BINDING_RESPONSE = 0x0101,
     STUN_BINDING_ERROR_RESPONSE = 0x0111,
     STUN_SHARED_SECRET_REQUEST = 0x0002,
     STUN_SHARED_SECRET_RESPONSE = 0x0102,
     STUN_SHARED_SECRET_ERROR_RESPONSE = 0x0112,
@@ skipping 23 matching lines @@
   };
 
   P2PSocketHost(IPC::Sender* message_sender, int id);
 
   // Verifies that the packet |data| has a valid STUN header. In case
   // of success stores type of the message in |type|.
   static bool GetStunPacketType(const char* data, int data_size,
                                 StunMessageType* type);
   static bool IsRequestOrResponse(StunMessageType type);
 
+  bool MaybeUpdateRtpSendTimeExtn(char* rtp, int length,
+                                  int extension_id);
+  bool GetRtpPacketStartPositionAndLength(char* data, int length,
+                                          int* rtp_start_pos,
+                                          int* rtp_packet_length);
+  bool ValidateRtpHeader(char* rtp, int length);
+  void UpdateSendTimeExtnValue(char* data, int len);

[Solis, 2014/02/26 15:49:34]

We are using the names

PacketSendTimeExtn
RtpSendTimeExtn
SendTimeExtn
and in the .cc also 
AbsSendTimeExtn

to refer to the same header extension. Can we stick to a single nomenclature? I
would prefer AbsoluteSenderTimeExtension, or if you must abbreviate,
AbsSendTimeExtn.

[Mallinath (Gone from Chromium), 2014/02/26 19:59:20]

Done. Using AbsSendTimeExtn.

+
+  void MaybeUpdateRtpAuthTag(char* packet, int len,
+                             const talk_base::PacketOptions& options);
+
   IPC::Sender* message_sender_;
   int id_;
   State state_;
 
   DISALLOW_COPY_AND_ASSIGN(P2PSocketHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_H_