This CL adds methods to manipulate RTP header extension, particularly

content/browser/renderer_host/p2p/socket_host_test_utils.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/p2p/socket_host_test_utils.h"
 
 #include "base/sys_byteorder.h"
 #include "base/thread_task_runner_handle.h"
 #include "net/base/completion_callback.h"
 #include "net/base/io_buffer.h"
 
 const int kStunHeaderSize = 20;
 const uint16 kStunBindingRequest = 0x0001;
 const uint16 kStunBindingResponse = 0x0102;
 const uint16 kStunBindingError = 0x0111;
 const uint32 kStunMagicCookie = 0x2112A442;
+const int kRtpHeaderSize = 12;
+const int kTurnChannelDataHdr = 4;
 
 MockIPCSender::MockIPCSender() { }
 MockIPCSender::~MockIPCSender() { }
 
 FakeSocket::FakeSocket(std::string* written_data)
     : read_pending_(false),
       input_pos_(0),
       written_data_(written_data),
       async_write_(false),
       write_pending_(false) {
@@ skipping 165 matching lines @@
 }
 
 void CreateStunRequest(std::vector<char>* packet) {
   CreateStunPacket(packet, kStunBindingRequest);
 }
 
 void CreateStunResponse(std::vector<char>* packet) {
   CreateStunPacket(packet, kStunBindingResponse);
 }
 
+
 void CreateStunError(std::vector<char>* packet) {
   CreateStunPacket(packet, kStunBindingError);
 }
 
+void CreateRtpPacket(std::vector<char>* packet) {
+ CreateRandomPacket(packet);  // Minimum length is 20 bytes.
+  *reinterpret_cast<uint8*>(&*packet->begin()) = 0x80;
+  // Extension bit not set.
+}
+
+void CreateRtpPacketWithSendtimeExtension(std::vector<char>* packet,

[juberti2, 2014/02/25 00:48:24]

SendTime->SendTime

[Mallinath (Gone from Chromium), 2014/02/25 22:56:44]

Done.

+                                          int extension_id) {
+ CreateRandomPacket(packet);
+  *reinterpret_cast<uint8*>(&*packet->begin()) = 0x90;
+  *reinterpret_cast<uint16*>(&*packet->begin() + kRtpHeaderSize) =
+      base::HostToNet16(0xBEDE);
+  *reinterpret_cast<uint16*>(&*packet->begin() + kRtpHeaderSize + 2) =
+      base::HostToNet16(2);
+  *reinterpret_cast<uint8*>(&*packet->begin() + kRtpHeaderSize + 4) =
+      (extension_id << 4) + 2;
+}
+
+void CreateTurnChannelData(std::vector<char>* packet) {
+  size_t size = kRtpHeaderSize + kTurnChannelDataHdr + rand() % 1000;

[juberti2, 2014/02/25 00:48:24]

instead of checking random sizes, i think we should form a valid packet and test
that packet by chopping off a byte at a time until it gets down to a zero-len
packet. That will ensure we cover all the too-short cases.

[Mallinath (Gone from Chromium), 2014/02/25 22:56:44]

Yea, removing these methods and adding test vector in stun_host_unittest.cc
On 2014/02/25 00:48:24, juberti2 wrote:

+  packet->resize(size);
+  *reinterpret_cast<uint16*>(&*packet->begin()) = base::HostToNet16(0x4000);
+  *reinterpret_cast<uint16*>(&*packet->begin() + 2) =
+      base::HostToNet16(size - 4);
+  // Write RTP header
+  *reinterpret_cast<uint8*>(&*packet->begin() + 4) = 0x80;

[juberti2, 2014/02/25 00:48:24]

this should call CreateRtpPacketWithSendTimeExtension to fill in a valid packet
with the extension.

[Mallinath (Gone from Chromium), 2014/02/25 22:56:44]

As above.
On 2014/02/25 00:48:24, juberti2 wrote:

+}
+
 net::IPEndPoint ParseAddress(const std::string ip_str, int port) {
   net::IPAddressNumber ip;
   EXPECT_TRUE(net::ParseIPLiteralToNumber(ip_str, &ip));
   return net::IPEndPoint(ip, port);
 }