Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 15935013: chrome_frame: Use base::MessageLoop. (Closed)

Created:
7 years, 6 months ago by xhwang
Modified:
7 years, 6 months ago
Reviewers:
ananta
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix license #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -54 lines) Patch
M chrome_frame/chrome_frame_automation.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/delete_chrome_history.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/delete_chrome_history.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/chrome_frame_automation_mock.h View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome_frame/test/chrome_frame_automation_mock.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome_frame/test/chrome_frame_ui_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/mock_ie_event_sink_actions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/net/test_automation_resource_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/net/test_automation_resource_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/proxy_factory_mock.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome_frame/test/test_server.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/test_server.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M chrome_frame/test/test_server_test.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome_frame/test/urlmon_moniker_integration_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/win_event_receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/urlmon_url_request.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
xhwang
PTAL
7 years, 6 months ago (2013-05-30 00:30:19 UTC) #1
ananta
lgtm
7 years, 6 months ago (2013-05-30 00:33:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/15935013/1
7 years, 6 months ago (2013-05-30 00:34:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/15935013/8001
7 years, 6 months ago (2013-05-30 00:51:51 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-05-30 01:15:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/15935013/8001
7 years, 6 months ago (2013-05-30 01:28:28 UTC) #6
xhwang
7 years, 6 months ago (2013-05-30 06:21:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r203096 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698