Remove hackish way of getting the url for browser testing

tools/testing/dart/test_runner.dart

Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart	(revision 23319)
+++ tools/testing/dart/test_runner.dart	(working copy)
@@ -406,6 +406,8 @@
 
   List<String> get batchTestArguments => _lastArguments.sublist(1);
 

[kustermann, 2013/05/29 08:16:11]

I'd really prefer if you pass it in via the BrowserTestCase constructor, assign
it to a private variable and make a getter for it.

[ricow1, 2013/05/29 08:25:42]

Done.

+  String testingUrl;
+
   /** Add a test case to listen for when this current test has completed. */
   void addObserver(BrowserTestCase testCase) {
     observers.add(testCase);
@@ -1661,13 +1663,8 @@
   }
 
   void _startBrowserControllerTest(var test) {
-    // Get the url.
-    // TODO(ricow): This is not needed when we have eliminated selenium.
-    var nextCommandIndex = test.commandOutputs.keys.length;
-    var url = test.commands[nextCommandIndex].toString().split("--out=")[1];
-    // Remove trailing "
-    url = url.split('"')[0];
     var callback = (var output) {
+      var nextCommandIndex = test.commandOutputs.keys.length;
       new CommandOutput.fromCase(test,
                                  test.commands[nextCommandIndex],
                                  0,
@@ -1679,7 +1676,9 @@
                                  false);
       test.completedHandler(test);
     };
-    BrowserTest browserTest = new BrowserTest(url, callback, test.timeout);
+    BrowserTest browserTest = new BrowserTest(test.testingUrl,
+                                              callback,
+                                              test.timeout);
     _getBrowserTestRunner(test).then((testRunner) {
       testRunner.queueTest(browserTest);
     });