Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: runtime/vm/assembler_mips.h

Issue 15934025: Enables more VM tests for SIMMIPS. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | runtime/vm/assembler_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_mips.h
===================================================================
--- runtime/vm/assembler_mips.h (revision 23873)
+++ runtime/vm/assembler_mips.h (working copy)
@@ -158,7 +158,7 @@
// Misc. functionality
int CodeSize() const { return buffer_.Size(); }
- int prologue_offset() const { return -1; }
+ int prologue_offset() const { return prologue_offset_; }
const ZoneGrowableArray<int>& GetPointerOffsets() const {
return buffer_.pointer_offsets();
}
@@ -205,14 +205,14 @@
const Code::Comments& GetCodeComments() const;
- static const char* RegisterName(Register reg) {
- UNIMPLEMENTED();
- return NULL;
- }
+ static const char* RegisterName(Register reg);
- static const char* FpuRegisterName(FpuRegister reg) {
- UNIMPLEMENTED();
- return NULL;
+ static const char* FpuRegisterName(FpuRegister reg);
+
+ void SetPrologueOffset() {
+ if (prologue_offset_ == -1) {
+ prologue_offset_ = CodeSize();
+ }
}
// A utility to be able to assemble an instruction into the delay slot.
@@ -816,7 +816,8 @@
}
void AddImmediate(Register rd, Register rs, int32_t value) {
- if (value == 0) return;
+ if ((value == 0) && (rd == rs)) return;
+ // If value is 0, we still want to move rs to rd if they aren't the same.
if (Utils::IsInt(kImmBits, value)) {
addiu(rd, rs, Immediate(value));
} else {
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | runtime/vm/assembler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698