Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/parser.cc

Issue 15934003: Remove checks for Expect and ExpectException from (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 23110)
+++ runtime/vm/parser.cc (working copy)
@@ -8353,10 +8353,7 @@
imported_obj = LookupNameInImport(import, name);
if (!imported_obj.IsNull()) {
lib ^= import.library();
- // TODO(8474): Remove the "Expect" special casing.
- if (!first_lib_url.IsNull()
- && (strcmp(name.ToCString(), "Expect") != 0)
- && (strcmp(name.ToCString(), "ExpectException") != 0)) {
+ if (!first_lib_url.IsNull()) {
// Found duplicate definition.
Error& ambiguous_ref_error = Error::Handle();
if (first_lib_url.raw() == lib.url()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698