Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 159329: Revert 19923 - Merge r15950.... (Closed)

Created:
9 years, 6 months ago by laforge
Modified:
7 years, 7 months ago
Reviewers:
Mark Larson, Yuzo
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Revert 19923 - Merge r15950. Make forward/backward navigation work even when redirection is involved. Currently, Chrome tries to go back to the page immediately before the current one. This doesn't work if the current page was visited by redirection; redirection just occurs again. With this change, Chrome first tries to find the redirection source of the current page and then to go back to the page before the source. BUG=9663, 10531 Tested: unit_tests, ui_tests, manually. TBR=mal@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -244 lines) Patch
MM chrome/browser/tab_contents/navigation_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
MM chrome/browser/tab_contents/navigation_controller.cc View 6 chunks +10 lines, -18 lines 0 comments Download
M chrome/test/data/History/HistoryHelper.js View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/History/history_length_test1.html View 1 chunk +66 lines, -0 lines 0 comments Download
M chrome/test/data/History/history_length_test2.html View 1 chunk +32 lines, -0 lines 0 comments Download
D chrome/test/data/History/history_length_test_page_1.html View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/test/data/History/history_length_test_page_2.html View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/test/data/History/history_length_test_page_3.html View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/test/data/History/history_length_test_page_4.html View 1 chunk +0 lines, -48 lines 0 comments Download
M chrome/test/ui/history_uitest.cc View 1 chunk +4 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
laforge
9 years, 6 months ago (2009-07-24 01:59:58 UTC) #1
Yuzo
LGTM
9 years, 6 months ago (2009-07-24 02:07:45 UTC) #2
Mark Larson
9 years, 6 months ago (2009-07-24 02:29:22 UTC) #3
Molto bene.

On 2009/07/24 02:07:45, Yuzo wrote:
> LGTM

Powered by Google App Engine
This is Rietveld 408576698