Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 159327: Disk cache: Avoid restarting the cache while it may be in use.... (Closed)

Created:
11 years, 5 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium
Visibility:
Public.

Description

Disk cache: Avoid restarting the cache while it may be in use. Now the code that releases resources runs from the message loop so that methods can cause the cache to disable itself while still being able to touch internal state. BUG=17604 TEST=unittests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M net/disk_cache/backend_impl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M net/disk_cache/backend_impl.cc View 4 chunks +9 lines, -3 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 4 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rvargas (doing something else)
11 years, 5 months ago (2009-07-24 01:31:21 UTC) #1
Nicolas Sylvain
11 years, 5 months ago (2009-07-24 18:04:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698