Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 159323003: Switch to use MayNamedAccess() in Runtime. (Closed)

Created:
6 years, 10 months ago by tfarina
Modified:
6 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Switch to use MayNamedAccess() in Runtime. BUG=None TEST=None R=yangguo@chromium.org LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/runtime.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
Is this right/ok?
6 years, 10 months ago (2014-02-10 23:59:04 UTC) #1
Yang
On 2014/02/10 23:59:04, tfarina wrote: > Is this right/ok? NOT LGTM. This is working as ...
6 years, 10 months ago (2014-02-11 07:56:55 UTC) #2
tfarina
6 years, 10 months ago (2014-02-11 12:38:40 UTC) #3
Message was sent while issue was closed.
I just thought it would be ok, because MayNamedAccessWrapper is said to be
temporary and is just an wrapper around MayNamedAccess().

In any case I have closed this CL.

Thanks for taking time to review it though!

Powered by Google App Engine
This is Rietveld 408576698