Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 159323: Make possible restarting extensions from the chrome://extensions/ page.... (Closed)

Created:
11 years, 5 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, Ben Goodger (Google)
Visibility:
Public.

Description

Make possible reloading extensions from the chrome://extensions/ page. http://crbug.com/16459 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21719

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -4 lines) Patch
M chrome/browser/extensions/extensions_service.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extensions_ui.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/resources/extensions_ui.html View 1 2 3 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Paweł Hajdan Jr.
11 years, 5 months ago (2009-07-24 00:45:10 UTC) #1
Aaron Boodman
There can be multiple ExtensionHosts for each extension process, so this code isn't quite right ...
11 years, 5 months ago (2009-07-24 03:59:43 UTC) #2
Paweł Hajdan Jr.
Please take a look to see if I'm on the right path. Currently when I ...
11 years, 5 months ago (2009-07-24 18:55:58 UTC) #3
Aaron Boodman
Looking better!
11 years, 5 months ago (2009-07-24 19:09:34 UTC) #4
Paweł Hajdan Jr.
Please review, I made sure it works now.
11 years, 5 months ago (2009-07-27 19:30:59 UTC) #5
Aaron Boodman
11 years, 5 months ago (2009-07-27 21:14:45 UTC) #6
lgtm with a nit

http://codereview.chromium.org/159323/diff/1028/14
File chrome/browser/extensions/extension_process_manager.h (right):

http://codereview.chromium.org/159323/diff/1028/14#newcode62
Line 62: ExtensionHost* GetExtensionHost(const std::string& extension_id);
This method is no longer used and should be removed.

Powered by Google App Engine
This is Rietveld 408576698