Issue 15932010: drive: Rename DriveWebApp* to DriveApp

Issue 15932010: drive: Rename DriveWebApp* to DriveApp (Closed)

Created:
7 years, 6 months ago by satorux1

Modified:
7 years, 6 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Rename DriveWebApp* to DriveApp The term "Drive app" is more commonly used than "Drive web app". BUG=242121 TEST=none R=hashimoto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202504

Patch Set 1 : #

Total comments: 8

Patch Set 2 : fixed a typo #

Patch Set 3 : address comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+155 lines, -705 lines)			Patch
A +	chrome/browser/chromeos/drive/drive_app_registry.h	View	1 2	7 chunks	+43 lines, -40 lines	0 comments	Download
A +	chrome/browser/chromeos/drive/drive_app_registry.cc	View		13 chunks	+51 lines, -51 lines	0 comments	Download
A +	chrome/browser/chromeos/drive/drive_app_registry_unittest.cc	View		5 chunks	+17 lines, -17 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_integration_service.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_integration_service.cc	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_url_request_job.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/chromeos/drive/drive_webapps_registry.h	View		1 chunk	+0 lines, -153 lines	0 comments	Download
D	chrome/browser/chromeos/drive/drive_webapps_registry.cc	View		1 chunk	+0 lines, -276 lines	0 comments	Download
D	chrome/browser/chromeos/drive/drive_webapps_registry_unittest.cc	View		1 chunk	+0 lines, -124 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc	View		6 chunks	+22 lines, -22 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_parser.h	View	1 2	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/chrome_browser_chromeos.gypi	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hashimoto

https://codereview.chromium.org/15932010/diff/2001/chrome/browser/chromeos/drive/drive_app_registry.h File chrome/browser/chromeos/drive/drive_app_registry.h (right): https://codereview.chromium.org/15932010/diff/2001/chrome/browser/chromeos/drive/drive_app_registry.h#newcode36 chrome/browser/chromeos/drive/drive_app_registry.h:36: const google_apis::InstalledApp::IconList& app_icons, nit: Indent https://codereview.chromium.org/15932010/diff/2001/chrome/browser/google_apis/drive_api_parser.h File chrome/browser/google_apis/drive_api_parser.h (right): ...

7 years, 6 months ago (2013-05-28 03:59:47 UTC) #2

satorux1

7 years, 6 months ago (2013-05-28 04:05:16 UTC) #3

satorux1

7 years, 6 months ago (2013-05-28 05:10:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r202504 (presubmit successful).

Expand Messages | Collapse Messages