Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 15931004: Pull the Blink headers on iOS (Closed)

Created:
7 years, 6 months ago by stuartmorgan
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Switch iOS to pulling Blink headers instead of WebKit headers iOS should pull the new Blink headers used by all the other platforms now that the mirror repo exists. The old WebKit header pull will be removed once nothing references headers in those locations any more. BUG=242829 R=blundell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202905

Patch Set 1 #

Patch Set 2 : Just add the Blink headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
stuartmorgan
This won't land until https://codereview.chromium.org/15936006/ lands and DEPS is rolled to pick it up.
7 years, 6 months ago (2013-05-29 08:49:44 UTC) #1
blundell
lgtm
7 years, 6 months ago (2013-05-29 08:54:57 UTC) #2
abarth-chromium
Presumably this CL will break the iOS build when it lands because we're still referencing ...
7 years, 6 months ago (2013-05-29 16:48:00 UTC) #3
stuartmorgan
On 2013/05/29 16:48:00, abarth wrote: > Presumably this CL will break the iOS build when ...
7 years, 6 months ago (2013-05-29 17:17:23 UTC) #4
stuartmorgan
Updated to just do the add.
7 years, 6 months ago (2013-05-29 17:43:36 UTC) #5
blundell
lgtm lgtm
7 years, 6 months ago (2013-05-29 17:45:22 UTC) #6
stuartmorgan
7 years, 6 months ago (2013-05-29 17:52:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r202905 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698