Issue 159304: Adds the first run banner....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159304: Adds the first run banner.... (Closed)

Created:
11 years, 5 months ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adds the first run banner. First run is determined by checking if there are no thumbnails. The check for no thumbnails is done on the backend since I need to add code to add some pre populated thumbnails and therefore the most visited pages will not be empty on the client. There is one edge case where the banner can show up again and that is if the user blacklists all his thumbnails and restarts chrome. Also, updates the look of the fillers to match the latest mocks. BUG=15079 TEST=Start with a new empty profile. You should see the blue first run banner. Then navigate to some link and come back the NTP. The banner should not be shown again. Also, test that this did not break the yellow notification banner shown when a thumbnail is removed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21480

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -35 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/new_tab_ui.cc	View	1 2	4 chunks	+21 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.css	View	1	4 chunks	+21 lines, -15 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.js	View	1 2	3 chunks	+53 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LG

Expand Messages | Collapse Messages

Issue 159304: Adds the first run banner.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages