Issue 159303: Implement location only display mode (used by popup windows).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159303: Implement location only display mode (used by popup windows). (Closed)

Created:
11 years, 5 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Implement location only display mode (used by popup windows). This matches the pixel sizes on Windows. The location bar is a couple pixels shorter and the font is a little smaller. BUG=17580

Patch Set 2 : review comments #

Patch Set 3 : fix crash #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -35 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_edit_view_gtk.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc	View	1	3 chunks	+9 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/browser_toolbar_gtk.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/browser_toolbar_gtk.cc	View	1 2	8 chunks	+34 lines, -13 lines	0 comments	Download
M	chrome/browser/gtk/location_bar_view_gtk.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/location_bar_view_gtk.cc	View		6 chunks	+42 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

LG http://codereview.chromium.org/159303/diff/1/2 File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right): http://codereview.chromium.org/159303/diff/1/2#newcode138 Line 138: gtk_util::ForceFontSizePixels(text_view_, 13.4); should 13.4 get pulled into ...

11 years, 5 months ago (2009-07-24 11:23:55 UTC) #2

Evan Stade

11 years, 5 months ago (2009-07-24 18:25:44 UTC) #3

lgtm

http://codereview.chromium.org/159303/diff/1/4
File chrome/browser/gtk/browser_toolbar_gtk.cc (right):

http://codereview.chromium.org/159303/diff/1/4#newcode144
Line 144: // Demand we're always at least kToolbarHeight tall.
update this comment? (imo you can just delete it)

http://codereview.chromium.org/159303/diff/1/4#newcode196
Line 196: ShouldOnlyShowLocation() ? 1 : 0);
can you make this arg flush with GTK_BOX on the line above