Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Issue 1592973003: Allow base path overrides when running a recipe. (Closed)

Created:
4 years, 11 months ago by luqui
Modified:
4 years, 4 months ago
Reviewers:
iannucci, martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
git@github.com:luci/recipes-py.git@isolate
Target Ref:
refs/heads/master
Project:
recipes-py
Visibility:
Public.

Description

Allow base path overrides when running a recipe. This is to allow running recipes via isolate, where we can't assume the normal infra directory layout. BUG=437264 R=iannucci@chromium.org,martiniss@chromium.org

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M recipe_engine/loader.py View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/path/api.py View 2 chunks +6 lines, -1 line 0 comments Download
M recipe_modules/path/config.py View 3 chunks +11 lines, -7 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 3 (1 generated)
luqui
ptal I am not sure if this is a good solution. First of all, I'm ...
4 years, 11 months ago (2016-01-16 05:40:09 UTC) #1
martiniss
4 years, 11 months ago (2016-01-19 23:29:38 UTC) #3
What if we make the recipe_engine do sym links into the recipe_deps? Hide the
weird hacky ness?

https://codereview.chromium.org/1592973003/diff/1/recipe_modules/path/config.py
File recipe_modules/path/config.py (right):

https://codereview.chromium.org/1592973003/diff/1/recipe_modules/path/config....
recipe_modules/path/config.py:54: c.base_paths.setdefault('slave_build', (
This won't work as is.... base_paths already has a value for slave_build, so
this won't change it. Should just assign here.

Powered by Google App Engine
This is Rietveld 408576698