Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1592973002: Devtools: Fix auto-expanding of arrays and function scopes in watches (Closed)

Created:
4 years, 11 months ago by sergeyv
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools: Fix auto-expanding of arrays and function scopes in watches BUG= Committed: https://crrev.com/f9fc6aeef30d310d1f03818ff187add0f60d32eb Cr-Commit-Position: refs/heads/master@{#370186}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html View 1 5 chunks +26 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion-expected.txt View 2 chunks +242 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js View 4 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sergeyv
4 years, 11 months ago (2016-01-16 02:50:16 UTC) #3
pfeldman
lgtm
4 years, 11 months ago (2016-01-16 02:51:22 UTC) #4
sergeyv
4 years, 11 months ago (2016-01-19 19:13:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1592973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1592973002/40001
4 years, 11 months ago (2016-01-19 19:14:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 11 months ago (2016-01-19 21:01:02 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 21:02:13 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f9fc6aeef30d310d1f03818ff187add0f60d32eb
Cr-Commit-Position: refs/heads/master@{#370186}

Powered by Google App Engine
This is Rietveld 408576698