The IPCs for carrying data requested by plugins have been changed from synchr...

The IPCs for carrying data requested by plugins have been changed from synchronous IPCs to asynchronous IPCs. 

This fixes bug http://code.google.com/p/chromium/issues/detail?id=14323, where the Flash plugin would not render
content on the page if these IPCs were processed while the plugin waited for sync calls like NPN_Evaluate to
return.

Test=covered by UI tests.

Bug=14323
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21548

[darin (slow to review), 2009-07-23 21:34:16]

woot!  more async IPCs FTW

On Thu, Jul 23, 2009 at 2:00 PM, <ananta@chromium.org> wrote:

> Reviewers: John Abd-El-Malek,
>
> Description:
> The IPCs for carrying data requested by plugins have been changed from
> synchronous IPCs to
> asynchronous IPCs.
>
> This fixes bug http://code.google.com/p/chromium/issues/detail?id=14323,
> where the Flash plugin would not render
> content on the page if these IPCs were processed while the plugin waited
> for sync calls like NPN_Evaluate to
> return.
>
> Bug=14323
>
>
> Please review this at http://codereview.chromium.org/159296
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/common/plugin_messages_internal.h
>  M     chrome/plugin/webplugin_delegate_stub.h
>  M     chrome/plugin/webplugin_delegate_stub.cc
>  M     chrome/plugin/webplugin_proxy.cc
>  M     chrome/renderer/webplugin_delegate_proxy.cc
>  M     webkit/glue/plugins/plugin_instance.cc
>  M     webkit/glue/plugins/plugin_stream_url.h
>  M     webkit/glue/plugins/plugin_stream_url.cc
>  M     webkit/glue/webplugin.h
>  M     webkit/glue/webplugin_impl.cc
>
>
>

[jam, 2009-07-23 23:11:42]

lgtm

is it possible to create a regression test for this?

[ananta, 2009-07-24 00:08:23]

On 2009/07/23 23:11:42, John Abd-El-Malek wrote:
> lgtm
> 
> is it possible to create a regression test for this?
Done. Updated the existing GetJavascriptUrl ui test to test for this case.

[jam, 2009-07-24 00:20:20]

cool thanks

On Thu, Jul 23, 2009 at 5:08 PM, <ananta@chromium.org> wrote:

> On 2009/07/23 23:11:42, John Abd-El-Malek wrote:
>
>> lgtm
>>
>
>  is it possible to create a regression test for this?
>>
> Done. Updated the existing GetJavascriptUrl ui test to test for this
> case.
>
>
>
>
> http://codereview.chromium.org/159296
>