Issue 159287: Close pop up notification when navigating to other site.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159287: Close pop up notification when navigating to other site. (Closed)

Created:
11 years, 5 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google), sky

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Close pop up notification when navigating to other site. When BlockedPopupContainer stopped being a ConstrainedWindow, the notification stopped being cleared in TabContents::MaybeCloseChildWindows. http://crbug.com/8622 http://crbug.com/14150 TEST=See 8622 for repro steps. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21445

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/tab_contents/tab_contents.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM