Clear the BLE services list on disconnect.

Clear the BLE services list on disconnect.

This lets us recreate the services list correctly upon the next
reconnect, which fixes some problems with a device we have, which
disconnects automatically after 30 seconds.

Also reset the services_discovered flag for this device on disconnect.
In order to accomplish this, I had to move this flag from the dispatcher
host, to the bluetooth device instance.

BUG=570804
Committed: https://crrev.com/5de5c0faa27a2ce80195d1dbda480ad4011f25ef
Cr-Commit-Position: refs/heads/master@{#369826}

[tommyt, 2016-01-15 12:21:21]

The CQ bit was checked by tommyt@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-15 12:21:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1592733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1592733002/20001

[commit-bot: I haz the power, 2016-01-15 12:21:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-15 12:21:24]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[tommyt, 2016-01-15 12:36:39]

Description was changed from

==========
Clear the BLE services list on disconnect.

This lets us recreate the services list correctly upon the next
reconnect, which fixes some problems with a device we have, which
disconnects automatically after 30 seconds.

Also reset the services_discovered flag for this device on disconnect.
In order to accomplish this, I had to move this flag from the dispatcher
host, to the bluetooth device instance.

BUG=570804
==========

to

==========
Clear the BLE services list on disconnect.

This lets us recreate the services list correctly upon the next
reconnect, which fixes some problems with a device we have, which
disconnects automatically after 30 seconds.

Also reset the services_discovered flag for this device on disconnect.
In order to accomplish this, I had to move this flag from the dispatcher
host, to the bluetooth device instance.

BUG=570804
==========

[tommyt, 2016-01-15 12:36:39]

tommyt@opera.com changed reviewers:
+ armansito@chromium.org, ortuno@chromium.org, scheib@chromium.org

[tommyt, 2016-01-15 12:40:21]

Hi! This is my second attempt to merge this change, as my previous attempt was
reverted due to it breaking a layout test. The timeout error in
bluetooth/getPrimaryService.html was caused by me missing one spot which needed
a device->SetGattServicesDiscoveryComplete(true) inside
layout_test_bluetooth_adapter_provider.cc.

I have now fixed this problem, and I hope you won't mind too much having another
look at my change. To make the reviewing job a bit easier for you, I've uploaded
my change in two patchsets. The first one is identical to the previous patchset
that was merged and reverted. The second patchset contains my (one-line) fix for
the broken test case.

Best regards,
Tommy Thorsen

[ortuno, 2016-01-15 18:13:20]

lgtm

[scheib, 2016-01-15 18:46:19]

LGTM. Thanks.

BTW, chromium-dev is split on how to handle re-landing patches, but I recommend
the style of re-uploading to the previous patch list (use git cl issue if
necessary) and using your judgement as to if fresh LGTMs are needed or not. E.g.
in this patch case I think you could just reland with fix and not need new LGTMs
- because the error was trivial and really just due to a try job not running -
if a try job had informed you after review and LGTMs but before landing you
would have fixed and landed without another LGTM round.

[scheib, 2016-01-15 18:46:23]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2016-01-15 18:46:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1592733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1592733002/20001

[scheib, 2016-01-15 18:47:03]

Also - thanks for the patch diff. ;)

[commit-bot: I haz the power, 2016-01-15 19:21:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-15 19:21:36]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ortuno, 2016-01-15 20:14:23]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2016-01-15 20:14:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1592733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1592733002/20001

[commit-bot: I haz the power, 2016-01-15 20:20:59]

Description was changed from

==========
Clear the BLE services list on disconnect.

This lets us recreate the services list correctly upon the next
reconnect, which fixes some problems with a device we have, which
disconnects automatically after 30 seconds.

Also reset the services_discovered flag for this device on disconnect.
In order to accomplish this, I had to move this flag from the dispatcher
host, to the bluetooth device instance.

BUG=570804
==========

to

==========
Clear the BLE services list on disconnect.

This lets us recreate the services list correctly upon the next
reconnect, which fixes some problems with a device we have, which
disconnects automatically after 30 seconds.

Also reset the services_discovered flag for this device on disconnect.
In order to accomplish this, I had to move this flag from the dispatcher
host, to the bluetooth device instance.

BUG=570804
==========

[commit-bot: I haz the power, 2016-01-15 20:21:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-15 20:22:24]

Description was changed from

==========
Clear the BLE services list on disconnect.

This lets us recreate the services list correctly upon the next
reconnect, which fixes some problems with a device we have, which
disconnects automatically after 30 seconds.

Also reset the services_discovered flag for this device on disconnect.
In order to accomplish this, I had to move this flag from the dispatcher
host, to the bluetooth device instance.

BUG=570804
==========

to

==========
Clear the BLE services list on disconnect.

This lets us recreate the services list correctly upon the next
reconnect, which fixes some problems with a device we have, which
disconnects automatically after 30 seconds.

Also reset the services_discovered flag for this device on disconnect.
In order to accomplish this, I had to move this flag from the dispatcher
host, to the bluetooth device instance.

BUG=570804

Committed: https://crrev.com/5de5c0faa27a2ce80195d1dbda480ad4011f25ef
Cr-Commit-Position: refs/heads/master@{#369826}
==========

[commit-bot: I haz the power, 2016-01-15 20:22:25]

Patchset 2 (id:??) landed as
https://crrev.com/5de5c0faa27a2ce80195d1dbda480ad4011f25ef
Cr-Commit-Position: refs/heads/master@{#369826}