Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1592733002: Clear the BLE services list on disconnect. (Closed)

Created:
4 years, 11 months ago by tommyt
Modified:
4 years, 11 months ago
Reviewers:
scheib, ortuno, armansito
CC:
chromium-reviews, darin-cc_chromium.org, jam, perja, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear the BLE services list on disconnect. This lets us recreate the services list correctly upon the next reconnect, which fixes some problems with a device we have, which disconnects automatically after 30 seconds. Also reset the services_discovered flag for this device on disconnect. In order to accomplish this, I had to move this flag from the dispatcher host, to the bluetooth device instance. BUG=570804 Committed: https://crrev.com/5de5c0faa27a2ce80195d1dbda480ad4011f25ef Cr-Commit-Position: refs/heads/master@{#369826}

Patch Set 1 : The original change that was reverted #

Patch Set 2 : Fix the bluetooth/getPrimaryService.html timeout issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -19 lines) Patch
M content/browser/bluetooth/bluetooth_dispatcher_host.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/browser/bluetooth/bluetooth_dispatcher_host.cc View 4 chunks +1 line, -9 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_bluez.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device.h View 3 chunks +9 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device.cc View 2 chunks +11 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_device_android.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_unittest.cc View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1592733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1592733002/20001
4 years, 11 months ago (2016-01-15 12:21:23 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
4 years, 11 months ago (2016-01-15 12:21:24 UTC) #4
tommyt
Hi! This is my second attempt to merge this change, as my previous attempt was ...
4 years, 11 months ago (2016-01-15 12:40:21 UTC) #7
ortuno
lgtm
4 years, 11 months ago (2016-01-15 18:13:20 UTC) #8
scheib
LGTM. Thanks. BTW, chromium-dev is split on how to handle re-landing patches, but I recommend ...
4 years, 11 months ago (2016-01-15 18:46:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1592733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1592733002/20001
4 years, 11 months ago (2016-01-15 18:46:44 UTC) #11
scheib
Also - thanks for the patch diff. ;)
4 years, 11 months ago (2016-01-15 18:47:03 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/166962)
4 years, 11 months ago (2016-01-15 19:21:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1592733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1592733002/20001
4 years, 11 months ago (2016-01-15 20:14:52 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 20:21:00 UTC) #18
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 20:22:25 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5de5c0faa27a2ce80195d1dbda480ad4011f25ef
Cr-Commit-Position: refs/heads/master@{#369826}

Powered by Google App Engine
This is Rietveld 408576698