src/compiler/ast-loop-assignment-analyzer.cc - Issue 1592713002: Clean up dead code after spread desugaring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-loop-assignment-analyzer.cc

Issue 1592713002: Clean up dead code after spread desugaring (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ast-loop-assignment-analyzer.cc

diff --git a/src/compiler/ast-loop-assignment-analyzer.cc b/src/compiler/ast-loop-assignment-analyzer.cc

index 2074c944e6237bf85ed44b65c1fcf8d93827320b..2ba4c96adc55e1bf72965cf935d1e4f313de23e0 100644

--- a/src/compiler/ast-loop-assignment-analyzer.cc

+++ b/src/compiler/ast-loop-assignment-analyzer.cc

@@ -198,7 +198,7 @@ void ALAA::VisitCompareOperation(CompareOperation* e) {

}

-void ALAA::VisitSpread(Spread* e) { Visit(e->expression()); }

+void ALAA::VisitSpread(Spread* e) { UNREACHABLE(); }

void ALAA::VisitEmptyParentheses(EmptyParentheses* e) { UNREACHABLE(); }