src/ast/ast-numbering.cc - Issue 1592713002: Clean up dead code after spread desugaring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/ast-numbering.cc

Issue 1592713002: Clean up dead code after spread desugaring (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast/ast-numbering.cc

diff --git a/src/ast/ast-numbering.cc b/src/ast/ast-numbering.cc

index 6c2b696a5df1eea3d8d2001e762c28f759d792c7..0ed35cac6c0671ab734374ad81594a2a1e6620c8 100644

--- a/src/ast/ast-numbering.cc

+++ b/src/ast/ast-numbering.cc

@@ -372,11 +372,7 @@ void AstNumberingVisitor::VisitCompareOperation(CompareOperation* node) {

}

-void AstNumberingVisitor::VisitSpread(Spread* node) {

- IncrementNodeCount();

- DisableCrankshaft(kSpread);

- Visit(node->expression());

+void AstNumberingVisitor::VisitSpread(Spread* node) { UNREACHABLE(); }

void AstNumberingVisitor::VisitEmptyParentheses(EmptyParentheses* node) {